Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:122256
MIME-Version: 1.0
References: <CAH5C8xW_CqSf1qybs9vG6qyo_1pzvbzkv5bVjUeyKNvAsTBdaw@mail.gmail.com>
 <CAH5C8xVW63ovb60mnmCq0anFdqSguUdAVT+tAbor2m_eDJQ1Zw@mail.gmail.com>
In-Reply-To: <CAH5C8xVW63ovb60mnmCq0anFdqSguUdAVT+tAbor2m_eDJQ1Zw@mail.gmail.com>
Date: Thu, 25 Jan 2024 15:13:54 +0100
Message-ID: <CAOWwgpkh7rc9_c0t1C-uTfZW29+-C8m8OikTc1=GohU90V0LNg@mail.gmail.com>
To: =?UTF-8?B?TcOhdMOpIEtvY3Npcw==?= <kocsismate90@gmail.com>
Cc: PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000f474a8060fc5caf2"
Subject: Re: [PHP-DEV] Re: [RFC] [Vote] Resource to object conversion
From: nicolas.grekas+php@gmail.com (Nicolas Grekas)

--000000000000f474a8060fc5caf2
Content-Type: text/plain; charset="UTF-8"

Hello Mate,

I've just closed the votes with the following outcomes:
> - The primary vote for the described approach for converting resources to
> objects was accepted unanimously (30 yes, 0 no)
> - Primary stream resources are going to be migrated in a major version,
> rather in any minor or major version (23 vs. 7 votes)
> - Auxiliary stream resources are going to be migrated in a major version,
> rather in any minor or major version (16 vs. 14 votes)
> - The Process resource is going to be migrated in the next major version,
> rather in the next minor or major version (15 vs. 14 votes)
> - Resources of other extensions are going to be migrated in any minor or
> major version, rather than in any major version (17 vs. 12 votes)
>

Congrats for this result :)

I just had a look at the Symfony codebase and FYI we do use
cast-to-integers for a few resources:

- for curl - that's already supported by CurlHandle so this is seamless
- for DBA, because dba_list() <https://www.php.net/dba_list> works by
resourceid
- for resources created by stream_socket_server() and stream_socket_accept()

I only checked situations where the resource id is used as an index in an
array, there might be some others (but not a lot, if any).

It looks like we should implement the cast to int for these resource types
at least.

Cheers,
Nicolas

--000000000000f474a8060fc5caf2--