Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:122238
MIME-Version: 1.0
References: <kii8EchCRNKJRI1IgoTQGYbxr2d0_BNN6dm4QrEFnWNaWLaH68cG-GioF5j6ebhIJv5wAVKdHojWk5XJqk9z_yL4cA0Fmb1KD0P19VrCiXU=@gpb.moe>
 <CAF-mU4ydv5f7=GnXPM_BMkKOxr_UGScKAkrbTVJ0Z6+nCByu1g@mail.gmail.com>
In-Reply-To: <CAF-mU4ydv5f7=GnXPM_BMkKOxr_UGScKAkrbTVJ0Z6+nCByu1g@mail.gmail.com>
Date: Wed, 24 Jan 2024 12:16:11 +0700
Message-ID: <CANLbj-pKB32nn0TgSOghzgqJP_QWLhFh1T51E+B1HzNLm_CRQg@mail.gmail.com>
To: =?UTF-8?Q?Rokas_=C5=A0leinius?= <rokas.sleinius@gmail.com>
Cc: "Gina P. Banyard" <internals@gpb.moe>, PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [PHP-DEV] [RFC] Deprecate implicitly nullable parameter type
From: ayesh@php.watch (Ayesh Karunaratne)

>
> I just encountered this language inconsistency when trying to remove
> nullable from a constructor-promoted property:
>
> ```
> class MyClass
> {
>     public function __construct(
>         public ?string $title = null // removing "?" here causes "Fatal
> error: Cannot use null as default value"
>     ) {
>        $this->title = $title ?: resolveTitle();
>     }
> }
> ```
>
> Which is fine, there's a simple workaround, it was just surprising.

Property types don't infer nullability from the default value being
null, so constructor properties don't allow it either. I'd say this is
not an inconsistency, but rather a *consistency* with what this RFC
proposes to deprecate and remove.

Highly supportive of this RFC :)