Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:122236
MIME-Version: 1.0
References: <CAPyj-LD2W0E+xz0Je5LscQ7d4UONxT2T1eZ0Pw6YjC3wHNbGhg@mail.gmail.com>
In-Reply-To: <CAPyj-LD2W0E+xz0Je5LscQ7d4UONxT2T1eZ0Pw6YjC3wHNbGhg@mail.gmail.com>
Date: Tue, 23 Jan 2024 11:41:04 -0800
Message-ID: <CAESVnVpMr+TPAwaRve_7sRmeZcLEu37iFH0cgsCQD98DQHxH2w@mail.gmail.com>
To: Ilija Tovilo <tovilo.ilija@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000002dc889060fa221f8"
Subject: Re: [PHP-DEV] [RFC][Vote] RFC1867 for non-POST HTTP verbs
From: pollita@php.net (Sara Golemon)

--0000000000002dc889060fa221f8
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Jan 22, 2024 at 1:24=E2=80=AFAM Ilija Tovilo <tovilo.ilija@gmail.co=
m> wrote:

> I started the vote on the "RFC1867 for non-POST HTTP verbs" RFC.
> https://wiki.php.net/rfc/rfc1867-non-post
>
>
Apologies for not seeing the discussion period, but I'll qualify my "No"
vote, because I'm actually +1 on the general concept, and this is just a
little bikeshedding (this RFC will pass even with a no vote from me).

1/ This function reaches into the SAPI to pull out the "special" body
data.  That's great, but what about uses where providing an input string
makes sense.  For that, and for point 2, I'd suggest
`http_parse_query(string $query, ?array $options =3D null): array|object`.

2/ `request_` represents a new psuedo-namespace, functions are easier to
find and associate if we keep them grouped.  I recommend 'http_` because it
compliments the very related function `http_build_query()`, and for the
version of this function which refers directly to the request:
`http_parse_request(?array $options =3D null) : array|object`.

-Sara

--0000000000002dc889060fa221f8--