Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:122232
Date: Tue, 23 Jan 2024 13:02:03 +0000
To: Juliette Reinders Folmer <php-internals_nospam@adviesenzo.nl>
Cc: internals@lists.php.net
Message-ID: <tNPcQy7Ucw_8vmp6_Wnue3-tD0Vt7YUhDfodyELb2rwDkQqIrim7DGb8DzlcWNlTDUcFEs6iaOtocHtz87vZzvpoz3VFu9uQ_uGiImnNibY=@gpb.moe>
In-Reply-To: <65AF2859.8000504@adviesenzo.nl>
References: <kii8EchCRNKJRI1IgoTQGYbxr2d0_BNN6dm4QrEFnWNaWLaH68cG-GioF5j6ebhIJv5wAVKdHojWk5XJqk9z_yL4cA0Fmb1KD0P19VrCiXU=@gpb.moe> <344c3e06-3822-4b20-9a6f-a58fb64929a7@app.fastmail.com> <pqNqnDTBZCeis6FA4j7mCDkENEfIpkN1-mUFziGcazrqbmp6GDQkFdlmOZVl0pUBdf_BJMCSPXz6Tqt19MCkUorZeXDCuC6fuAPBbxU4LzQ=@gpb.moe> <65AF2859.8000504@adviesenzo.nl>
Feedback-ID: 96993444:user:proton
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] [RFC] Deprecate implicitly nullable parameter type
From: internals@gpb.moe ("Gina P. Banyard")

On Tuesday, 23 January 2024 at 02:45, Juliette Reinders Folmer <php-interna=
ls_nospam@adviesenzo.nl> wrote:
> On 23-1-2024 3:18, Gina P. Banyard wrote:
> > > The RFC notes that PHPStan and friends have an easy flag to make the =
change, which is great, but still that's a minority of PHP devs that even k=
now to use static analysis.
> > > One does not need to use a static analyser to determine or fix this i=
ssue, indeed, I didn't even mention static analysers in the RFC as PHP_CS_F=
IXER is a tool for enforcing coding styles and is capable of fixing this is=
sue.
> > > This tool and other code formatting tools are used more widely and fo=
r longer than static analysers.
>=20
> While I concur that too few devs use the helpful tooling available to
> them, I can already tell you that PHPCompatibility for PHP_CodeSniffer
> will be able to detect and flag code subject to this deprecation without
> problems and I will make sure the sniff is available ahead of the PHP
> 8.4 release (providing the RFC passes).
>=20
> And the Slevomat Coding Standard for PHP_CodeSniffer already contains
> the `SlevomatCodingStandard.TypeHints.NullableTypeForNullDefaultValue`
> sniff to auto-fix non-nullable typed parameters with a `null` default
> value to be nullable typed as well, so it's not just CS-Fixer which can
> help with this.


I had a hunch that PHP_CodeSniffer was able to handle this already, I just =
couldn't find the correct sniff. :)
I'll mention it if/when I update the RFC text.

Best regards,

Gina P. Banyard