Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:122231
To: internals@lists.php.net
References: <kii8EchCRNKJRI1IgoTQGYbxr2d0_BNN6dm4QrEFnWNaWLaH68cG-GioF5j6ebhIJv5wAVKdHojWk5XJqk9z_yL4cA0Fmb1KD0P19VrCiXU=@gpb.moe>
 <344c3e06-3822-4b20-9a6f-a58fb64929a7@app.fastmail.com>
 <pqNqnDTBZCeis6FA4j7mCDkENEfIpkN1-mUFziGcazrqbmp6GDQkFdlmOZVl0pUBdf_BJMCSPXz6Tqt19MCkUorZeXDCuC6fuAPBbxU4LzQ=@gpb.moe>
Message-ID: <65AF2859.8000504@adviesenzo.nl>
Date: Tue, 23 Jan 2024 03:45:45 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.0
MIME-Version: 1.0
In-Reply-To: <pqNqnDTBZCeis6FA4j7mCDkENEfIpkN1-mUFziGcazrqbmp6GDQkFdlmOZVl0pUBdf_BJMCSPXz6Tqt19MCkUorZeXDCuC6fuAPBbxU4LzQ=@gpb.moe>
Content-Type: multipart/alternative;
 boundary="------------080109060306050104070106"
Subject: Re: [PHP-DEV] [RFC] Deprecate implicitly nullable parameter type
From: php-internals_nospam@adviesenzo.nl (Juliette Reinders Folmer)

--------------080109060306050104070106
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit

On 23-1-2024 3:18, Gina P. Banyard wrote:
>> The RFC notes that PHPStan and friends have an easy flag to make the change, which is great, but still that's a minority of PHP devs that even know to use static analysis.
> One does not need to use a static analyser to determine or fix this issue, indeed, I didn't even mention static analysers in the RFC as PHP_CS_FIXER is a tool for enforcing coding styles and is capable of fixing this issue.
> This tool and other code formatting tools are used more widely and for longer than static analysers.
While I concur that too few devs use the helpful tooling available to 
them, I can already tell you that PHPCompatibility for PHP_CodeSniffer 
will be able to detect and flag code subject to this deprecation without 
problems and I will make sure the sniff is available ahead of the PHP 
8.4 release (providing the RFC passes).

And the Slevomat Coding Standard for PHP_CodeSniffer already contains 
the `SlevomatCodingStandard.TypeHints.NullableTypeForNullDefaultValue` 
sniff to auto-fix non-nullable typed parameters with a `null` default 
value to be nullable typed as well, so it's not just CS-Fixer which can 
help with this.

Smile,
Juliette

--------------080109060306050104070106--