Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:122184
MIME-Version: 1.0
References: <bcca1ceb3d205fb15251d6010f91d36c@xpple.dev> <6246AF4D-C204-443C-9056-F662E59AA687@sakiot.com>
In-Reply-To: <6246AF4D-C204-443C-9056-F662E59AA687@sakiot.com>
Date: Fri, 19 Jan 2024 09:51:09 +0900
Message-ID: <CAOyH9yQc=kwA2yjf48S9NP9kFj2oCBnEQzYTTZE-T-mkh7687Q@mail.gmail.com>
To: Saki Takamachi <saki@sakiot.com>
Cc: php@xpple.dev, Niels Dossche <dossche.niels@gmail.com>, internals@lists.php.net
Content-Type: multipart/alternative; boundary="000000000000f1f2bf060f41e043"
Subject: Re: [PHP-DEV] `PDO::FETCH_CONSTRUCTOR` fetch mode proposal
From: alex.pravdin@interi.co (Alexander Pravdin)

--000000000000f1f2bf060f41e043
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

I would also suggest supporting readonly classes and creating special
attributes to help map data fields to constructor arguments. Something like
this:

readonly class User {
    public function  __construct(
        #[PDOField('user_id')]
        public string $userId,
        #[PDOField('user_name')]
        public string $userName,
        #[PDOField('user_address')]
        public ?string $userAddress =3D '', // Optional field with default
value
    );
}

--
Best regards,
Alex


On Fri, Jan 19, 2024 at 9:05=E2=80=AFAM Saki Takamachi <saki@sakiot.com> wr=
ote:

> Hi Frederik
>
> > First off, please excuse me if I=E2=80=99ve done something wrong relate=
d to the
> usage of the mailing list. This all is completely new to me.
>
> Welcome to the internal mailing list! I had looked the pull request, and
> I'm pleased to have received your email promptly.
>
> > Thank you, the link was originally on the text "on GitHub" but it seems
> to have been stripped.
>
> Since mailing lists are text rather than HTML, you cannot attach links to
> strings.
>
> > I hereby want to propose a new fetch mode for PDO. I=E2=80=99ve detaile=
d the
> motivation for it on GitHub. I haven=E2=80=99t actually written the code =
for it,
> but it should not be too difficult.
>
> Now, I agree that it is often not possible to use `PDO::FETCH_CLASS`
> because DB column names are typically snake case and variables and
> properties are camel case.
>
> IMHO, passing arguments to the constructor in order is a good approach,
> but I think another option would be to give attributes to properties and
> map data appropriately when using PDO::FETCH_CLASS.
>
> e.g.
> ```
> #[ColumnName('user_name')]
> private string $userName;
> ```
>
> In addition to the concerns mentioned in the pull request, I'm also
> concerned that more modes with similar functionality will confuse users.
>
> Regards.
>
> Saki
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: https://www.php.net/unsub.php
>
>

--000000000000f1f2bf060f41e043--