Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:122182
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0 (1.0)
In-Reply-To: <bcca1ceb3d205fb15251d6010f91d36c@xpple.dev>
Cc: Niels Dossche <dossche.niels@gmail.com>, internals@lists.php.net
Date: Fri, 19 Jan 2024 09:04:56 +0900
Message-ID: <6246AF4D-C204-443C-9056-F662E59AA687@sakiot.com>
References: <bcca1ceb3d205fb15251d6010f91d36c@xpple.dev>
To: php@xpple.dev
Subject: Re: [PHP-DEV] `PDO::FETCH_CONSTRUCTOR` fetch mode proposal
From: saki@sakiot.com (Saki Takamachi)

Hi Frederik

> First off, please excuse me if I=E2=80=99ve done something wrong related t=
o the usage of the mailing list. This all is completely new to me.

Welcome to the internal mailing list! I had looked the pull request, and I'm=
 pleased to have received your email promptly.

> Thank you, the link was originally on the text "on GitHub" but it seems to=
 have been stripped.

Since mailing lists are text rather than HTML, you cannot attach links to st=
rings.

> I hereby want to propose a new fetch mode for PDO. I=E2=80=99ve detailed t=
he motivation for it on GitHub. I haven=E2=80=99t actually written the code f=
or it, but it should not be too difficult.

Now, I agree that it is often not possible to use `PDO::FETCH_CLASS` because=
 DB column names are typically snake case and variables and properties are c=
amel case.

IMHO, passing arguments to the constructor in order is a good approach, but I=
 think another option would be to give attributes to properties and map data=
 appropriately when using PDO::FETCH_CLASS.

e.g.
```
#[ColumnName('user_name')]
private string $userName;
```

In addition to the concerns mentioned in the pull request, I'm also concerne=
d that more modes with similar functionality will confuse users.

Regards.

Saki=