Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:122166
Feedback-ID: id4a9467a:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-1374-gc37f3abe3d-fm-20240102.001-gc37f3abe
MIME-Version: 1.0
Message-ID: <aedbc1e7-ce08-4471-bcd4-a07f3f176f0d@app.fastmail.com>
In-Reply-To: 
 <CALZWoqVNYKxUhs2Kg3yw+p69Q8Z0zoJiMmnoeecjmZmVvSgW4g@mail.gmail.com>
References: <1e22de79-1756-4eac-bdec-eefa0815db74@gmail.com>
 <CALZWoqVNYKxUhs2Kg3yw+p69Q8Z0zoJiMmnoeecjmZmVvSgW4g@mail.gmail.com>
Date: Tue, 16 Jan 2024 22:34:19 +0100
To: "Nuno Maduro" <enunomaduro@gmail.com>,
 "Daniil Gentili" <daniil.gentili@gmail.com>
Cc: "Levi Morrison" <internals@lists.php.net>
Content-Type: multipart/alternative;
 boundary=5bbed74e6d9d4b58ae8a6dfeaf3ca657
Subject: Re: [PHP-DEV] [VOTE] [RFC] Final-by-default anonymous classes
From: nikita.ppv@gmail.com ("Nikita Popov")

--5bbed74e6d9d4b58ae8a6dfeaf3ca657
Content-Type: text/plain

On Mon, Jan 15, 2024, at 13:54, Nuno Maduro wrote:
> On Mon, 15 Jan 2024 at 10:36, Daniil Gentili <daniil.gentili@gmail.com>
> wrote:
> 
> > Hi all,
> >
> > I've opened voting for the final-by-default anonymous classes RFC:
> > https://wiki.php.net/rfc/final_by_default_anonymous_classes
> >
> > Regards,
> >
> > Daniil Gentili.
> >
> 
> Hi Daniil,
> 
> Thank you for your work on this RFC. In my opinion, this RFC should not
> move forward for consistency reasons. If regular class definitions are
> non-final by default, anonymous classes should be non-final too.

I don't think that consistency is a good argument here, because anonymous classes are qualitatively different in this regard. In order to extend a class you need to name it -- which *should* be impossible-by-design for an anonymous class.

Unfortunately, due to an implementation oversight, this is not actually true. I consider the fact that extending anonymous classes is possible to be a bug, which is why I also accept the minor backwards compatibility break that comes with fixing it. Of course, the line between a bug and a feature is quite fine sometimes, so I understand that people have differing views on where this falls.

Regards,
Nikita

--5bbed74e6d9d4b58ae8a6dfeaf3ca657--