Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:122102
MIME-Version: 1.0
References: <JmodrpwuVz43pzkm6Ok1P6SNx-ayT9ZJ1EvPazHh1Jqp7uT-RsqomzHc2-YYC2Qhq6DqJzWcltUMxo0xnAxpEWi8gccFPwJN7t43vkchbl8=@gpb.moe>
 <CABdc3WrdAUNDo6cwE7V9R3E-+KHCw4FZxkJJXrnMkY5GNdpR7A@mail.gmail.com> <8_ddez_Ykz3hKB4zkdYVhxWjHTwlWzYjo4rfojNiWMPF79rHAu2tQ3JMsqwMh8YkZUCVbZp2uZWj0vNBmVkbHFj6kA1_dSY0qD5S_Gb9CG8=@gpb.moe>
In-Reply-To: <8_ddez_Ykz3hKB4zkdYVhxWjHTwlWzYjo4rfojNiWMPF79rHAu2tQ3JMsqwMh8YkZUCVbZp2uZWj0vNBmVkbHFj6kA1_dSY0qD5S_Gb9CG8=@gpb.moe>
Date: Wed, 3 Jan 2024 16:22:27 +0100
Message-ID: <CABdc3WoD3P4uSneodW3QAr2FPfWSAezwfaMGKA4rw8uA4y_JLQ@mail.gmail.com>
To: "Gina P. Banyard" <internals@gpb.moe>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000079c7fe060e0c2f61"
Subject: Re: [PHP-DEV] [RFC] Add http_(get|clear)_last_request_headers() function
From: michal.brzuchalski@gmail.com (=?UTF-8?Q?Micha=C5=82_Marcin_Brzuchalski?=)

--00000000000079c7fe060e0c2f61
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

=C5=9Br., 3 sty 2024 o 15:57 Gina P. Banyard <internals@gpb.moe> napisa=C5=
=82(a):

> On Wednesday, 3 January 2024 at 14:38, Micha=C5=82 Marcin Brzuchalski <
> michal.brzuchalski@gmail.com> wrote:
>
> Hi Gina,
>
> =C5=9Br., 3 sty 2024 o 14:41 Gina P. Banyard <internals@gpb.moe> napisa=
=C5=82(a):
>
> Hello internals,
>
> I would like to propose an RFC to add the functions
> http_get_last_request_headers() and http_clear_last_request_headers() to
> PHP to replace the magic variable $http_response_header.
>
> Link: https://wiki.php.net/rfc/http-last-response-headers
>
>
> I was on the specific documentation page describing this feature Today an=
d
> was thinking that it is inappropriate as well.
> But my thinking was whether it shouldn't be a part of a stream context
> instead, something like this:
>
> $response_headers;
> $context =3D stream_context_create([
> 'http' =3D> ['response_headers' =3D> &$response_headers]
> ]);
> $result =3D file_get_contents('http://example.com/submit.php', false,
> $context);
>
> This way by ref you get a specific HTTP wrapper running under the hood
> response headers instead of just the last one.
> Any thoughts about that?
>
>
> I don't understand why the response should be part of the context of a
> stream.
> Especially as I'm not aware of anything within the context that changes
> values after a request?
>

My thinking was like passing as part of the context a placeholder by ref
where the headers of requests done in this context are to be populated.
This means instead of calling http_get_last_request_headers() as you
propose just read them from $response_headers array which got populated
during the HTTP call.
In general the same to what Aleksander asked.

Cheers

--00000000000079c7fe060e0c2f61--