Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:122094
MIME-Version: 1.0
References: <CAGgaK7+w_zdp30Pi5nJ-y+GPEkfc2xHfFUW+DwdpNtY8iPjMHg@mail.gmail.com>
 <CAOWwgpkW65ngNVrtu3oZ3_yAw4W+Qe1DsQ9LN-pfet_Psdy==Q@mail.gmail.com>
In-Reply-To: <CAOWwgpkW65ngNVrtu3oZ3_yAw4W+Qe1DsQ9LN-pfet_Psdy==Q@mail.gmail.com>
Date: Wed, 3 Jan 2024 16:17:19 +0300
Message-ID: <CAGgaK7L-kYiw3r3E6HC+ONdNSa6x9oTXet4Wcc4j50EsMnaTcw@mail.gmail.com>
To: Nicolas Grekas <nicolas.grekas+php@gmail.com>
Cc: Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000ec0eb0060e0a6f59"
Subject: Re: [PHP-DEV] [RFC][Discussion] NotSerializable attribute
From: maxsem.wiki@gmail.com (Max Semenik)

--000000000000ec0eb0060e0a6f59
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Jan 3, 2024 at 10:11=E2=80=AFAM Nicolas Grekas <nicolas.grekas+php@=
gmail.com>
wrote:

>
> Regarding the inheritance-related behavior ("The non-serializable flag is
> inherited by descendants"), this is very unlike any other attributes, and
> this actively prevents writing a child class that'd make a parent
> serializable if it wants to.
>
> To me, if this is really the behavior we want, then the attribute should
> be replaced by a maker interface.
> Then, a simple "instanceof NotSerializable" would be enough instead of
> adding yet another method to ReflectionClass.
>

As explained in the RFC, this implementation hooks to the already existing
feature. Additionally, checking a bit in zend_class_entry::ce_flags is much
faster than checking inheritance.

> this actively prevents writing a child class that'd make a parent
serializable if it wants to.

Wouldn't this violate LSP?

--=20
Best regards,
Max Semenik

--000000000000ec0eb0060e0a6f59--