Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:122087
MIME-Version: 1.0
References: <CAGgaK7+w_zdp30Pi5nJ-y+GPEkfc2xHfFUW+DwdpNtY8iPjMHg@mail.gmail.com>
In-Reply-To: <CAGgaK7+w_zdp30Pi5nJ-y+GPEkfc2xHfFUW+DwdpNtY8iPjMHg@mail.gmail.com>
Date: Wed, 3 Jan 2024 08:11:44 +0100
Message-ID: <CAOWwgpkW65ngNVrtu3oZ3_yAw4W+Qe1DsQ9LN-pfet_Psdy==Q@mail.gmail.com>
To: Max Semenik <maxsem.wiki@gmail.com>
Cc: Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000a99ec5060e05543f"
Subject: Re: [PHP-DEV] [RFC][Discussion] NotSerializable attribute
From: nicolas.grekas+php@gmail.com (Nicolas Grekas)

--000000000000a99ec5060e05543f
Content-Type: text/plain; charset="UTF-8"

Hi Max,

Hi, I'd like to propose a new attribute, #[NotSerializable]. This
> functionality is already available for internal classes - userspace should
> benefit from it, too.
>
> The RFC: https://wiki.php.net/rfc/not_serializable
> Proposed implementation: https://github.com/php/php-src/pull/12788
>
> Please let me know what you think.
>

Regarding the inheritance-related behavior ("The non-serializable flag is
inherited by descendants"), this is very unlike any other attributes, and
this actively prevents writing a child class that'd make a parent
serializable if it wants to.

To me, if this is really the behavior we want, then the attribute should be
replaced by a maker interface.
Then, a simple "instanceof NotSerializable" would be enough instead of
adding yet another method to ReflectionClass.

Cheers,
Nicolas

--000000000000a99ec5060e05543f--