Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:121964
Message-ID: <1a8b451a-1d4c-4c2b-9d1c-aefd2fd51e49@gmail.com>
Date: Fri, 8 Dec 2023 17:08:52 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: internals@lists.php.net
References: <CAEwRQKbHFD_BBV1PDgj8RmdUXwGzXcCvem=GgAeiNVgPzjC3cg@mail.gmail.com>
 <CAG=Eydhgyh4pcWbJr-RgyJv_iyaf9TG+n5uqvY5Ozz0x5HJuLA@mail.gmail.com>
 <CAEwRQKYNZkXdd-kmpiRr0sJ3Yw4tixUo80QqZjRAfghfqYwj8A@mail.gmail.com>
Content-Language: en-US
In-Reply-To: <CAEwRQKYNZkXdd-kmpiRr0sJ3Yw4tixUo80QqZjRAfghfqYwj8A@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] PHP test coverage
From: dossche.niels@gmail.com (Niels Dossche)

Hi

On 08/12/2023 17:04, Vinicius Dias wrote:
>> The code coverage report can be found at https://app.codecov.io/github/php/php-src
> 
> Ah, perfect. Thank you for sharing. I will take a closer look after
> work, but something seems weird to me. Here[1] you see that
> ctype_alpha seems to be uncovered, but here[2] we can see that it's
> tested.
> 
> [1]: https://app.codecov.io/github/php/php-src/blob/master/ext%2Fctype%2Fctype.c#L112
> [2]: https://github.com/php/php-src/blob/master/ext/ctype/tests/ctype_alpha_basic.phpt

You'll see this kind of stuff with macros.
The coverage report shows "partially covered" code as uncovered due to a limitation.
In this particular example, the parameter parsing code failure isn't tested, so it marks the whole macro as untested.

You'll see this many times in the PHP codebase.
Also for example for RETURN_THROWS: because that macro performs an assertion it's always in red because the assertion isn't hit in our testing (and that's a good thing because if it were hit then it means there's a bug).

Kind regards
Niels

> 
> 
>> I will have a look, the page overall looks like it could need some love ;-)
>> In the meantime if you are interested in writing tests, I once wrote a blog post about that topic at https://dev.to/realflowcontrol/growing-the-php-core-one-test-at-a-time-4g4k
> Ah, that's great. Thank you for that! :-D
>