Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:121963 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 82051 invoked from network); 8 Dec 2023 16:04:21 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 8 Dec 2023 16:04:21 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 2BBE018005A for ; Fri, 8 Dec 2023 08:04:34 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,DMARC_PASS, FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=4.0.0 X-Spam-Virus: No X-Envelope-From: Received: from mail-qk1-f181.google.com (mail-qk1-f181.google.com [209.85.222.181]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Fri, 8 Dec 2023 08:04:33 -0800 (PST) Received: by mail-qk1-f181.google.com with SMTP id af79cd13be357-77f2dc3a9bcso101413285a.3 for ; Fri, 08 Dec 2023 08:04:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702051459; x=1702656259; darn=lists.php.net; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=0Kksl19aranwaL6VvOPFUVAZXu2omSbTSpgTVwIs0O8=; b=mX/jL4aUXgUq8zYP9btZnL14pkZgpAxkfi7IWVymUK6t8uGchfsBMSqISWcIGrjQBN xWGOi1kljW9bOJ61lutduY1rQfnCRH4Dy+PMQKrEpyHyP5yN3y+HRXMmVI0X49W4NgS2 qYnjtRG3x9fu0d2VFCNXIYaO+uLoIVXsYbtLJdpqnxjHqG28DD95YMod54uiqJlDFwad LoMpNDWNDdXPxVk3ItYJtV3JfwA5XTPTc2cgbh7+yz/KmMS6PiBBtqcBLUUuY0XMjlGG Ed1pMq7oxluHcB+sP/TmGOnENf8n4HEwBHh7oGQrj9KwrGLpjgsZrer32t5pAewxajFA XeYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702051459; x=1702656259; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0Kksl19aranwaL6VvOPFUVAZXu2omSbTSpgTVwIs0O8=; b=uSgi5D1GWB2UIDvBheWwf3zcmNZfWCFd1gOxj7vdw5DkegVgmGz7xvvN+DoIL1BmaB utxiTXfJ6zZUem9G1YhJUShoL+rP9/dMHmDVwIaZwC0o/e4bYBweUzPznR54mTl5Y8wb lRnJnU7fOH87yY7XavcLUSuQWQomz+6b83VzSB6vyQVsgqTFGzvYf8JHQlvxoj8Qvb5Y x8z7ec6xzRzagqacYvxF6Zl8ld55ZA80SM4mw/1yH0Z2I7+n7A9wjy7l70KIvt6i+9N4 u7J2XLif44dXAti7phRkbnHLJ4CltO9XtDE1wnVDPYb0puCVY8WV9/UHhNsrpbn+fzeZ LM+g== X-Gm-Message-State: AOJu0YzWW4Oi6nqe/7Uxih0TbJehVwKiYUTeASGA5pi79htAJkhCOgW2 qDisAdy+F3aOpdZov/rtBvOgcpgTOvM+iEhGSjovpcmZJNNm4jCZ X-Google-Smtp-Source: AGHT+IFIvt7KkZPlyLF6LVENsatmetR4I8JnS/Y09M4kIPbuS3WSDqQd8woUlg7OGyUwPUL/k6exXPH2eY4eIxvzbr0= X-Received: by 2002:a05:622a:54c:b0:425:9561:4308 with SMTP id m12-20020a05622a054c00b0042595614308mr360731qtx.122.1702051459028; Fri, 08 Dec 2023 08:04:19 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: Date: Fri, 8 Dec 2023 13:04:09 -0300 Message-ID: To: Florian Engelhardt Cc: PHP internals Content-Type: text/plain; charset="UTF-8" Subject: Re: [PHP-DEV] PHP test coverage From: carlosv775@gmail.com (Vinicius Dias) > The code coverage report can be found at https://app.codecov.io/github/php/php-src Ah, perfect. Thank you for sharing. I will take a closer look after work, but something seems weird to me. Here[1] you see that ctype_alpha seems to be uncovered, but here[2] we can see that it's tested. [1]: https://app.codecov.io/github/php/php-src/blob/master/ext%2Fctype%2Fctype.c#L112 [2]: https://github.com/php/php-src/blob/master/ext/ctype/tests/ctype_alpha_basic.phpt > I will have a look, the page overall looks like it could need some love ;-) > In the meantime if you are interested in writing tests, I once wrote a blog post about that topic at https://dev.to/realflowcontrol/growing-the-php-core-one-test-at-a-time-4g4k Ah, that's great. Thank you for that! :-D