Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:121896
MIME-Version: 1.0
References: <6566989F.7010305@adviesenzo.nl>
In-Reply-To: <6566989F.7010305@adviesenzo.nl>
Date: Fri, 1 Dec 2023 13:33:18 +0100
Message-ID: <CADyq6s+AfhhO_b-Dyub3uHzQOkpK3=vswer6oqN-iqocnGFmrA@mail.gmail.com>
To: Juliette Reinders Folmer <php-internals_nospam@adviesenzo.nl>
Cc: "internals@lists.php.net >> PHP internals" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000d27a0c060b71f969"
Subject: Re: [PHP-DEV] What is the prevailing sentiment about extract() and
 compact() ?
From: ocramius@gmail.com (Marco Pivetta)

--000000000000d27a0c060b71f969
Content-Type: text/plain; charset="UTF-8"

Hey Juliette,

On Wed, 29 Nov 2023 at 03:00, Juliette Reinders Folmer <
php-internals_nospam@adviesenzo.nl> wrote:

>
> For now, I'm just wondering how people feel about these functions.
>

From my PoV: burn them with fire.
The translation of `compact()` is **trivial** with a CS tool (like the one
you maintain), and the translation of `extract($vars)` is `foreach ($vars
as $k => $v) { $$k = $v; }`, and that's all there is.

Instead, both `compact()` and `extract()` come at additional cognitive load
when reading, scanning, analyzing, debugging and generally understanding
code: a flamethrower helps.

Meanwhile, I'm also wondering if the removal of such functions would help
more in future AOT and JIT improvements: I suppose code using `extract()`
and `compact()` would immediately defeat any JIT, or at least lead to added
code to handle them correctly?

There's a section describing this in HHVM, which is the kind of
problem-space I was thinking of:
https://hhvm.com/blog/713/hhvm-optimization-tips


Marco Pivetta

https://mastodon.social/@ocramius

https://ocramius.github.io/

--000000000000d27a0c060b71f969--