Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:121863
MIME-Version: 1.0
References: <6566989F.7010305@adviesenzo.nl> <34dada8e-7f2a-4d94-b7df-d9d3c7b2f3ce@app.fastmail.com>
 <F200E6CF-5116-4361-AB5C-CDD67F2E2021@koalephant.com>
In-Reply-To: <F200E6CF-5116-4361-AB5C-CDD67F2E2021@koalephant.com>
Date: Wed, 29 Nov 2023 20:17:06 +0000
Message-ID: <CA+p1FaZ8cqqSx2q4-s3Nb7p+Cu6oz_WUMBq_3DXvxj62-B9UEA@mail.gmail.com>
To: Stephen Reay <php-lists@koalephant.com>
Cc: php internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000ba5865060b503864"
Subject: Re: [PHP-DEV] What is the prevailing sentiment about extract() and
 compact() ?
From: davidgebler@gmail.com (David Gebler)

--000000000000ba5865060b503864
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Nov 29, 2023 at 7:19=E2=80=AFAM Stephen Reay <php-lists@koalephant.=
com>
wrote:

> So no, I don't think compact() should be deprecated, what I think *should=
*
> happen, is to promote the current warning on undefined variables, to an
> error, as per https://wiki.php.net/rfc/undefined_variable_error_promotion=
.
> Whether this is a foregone conclusion or not, I don't know because that R=
FC
> doesn't mention compact() specifically.
>
>
I remember fixing a bug in compact where passing parameters which were not
array or string were silently accepted - something I discovered when I was
tracking down a bug in my code once and it turned out I'd accidentally done
compact($x) instead of compact('x') - and that now gives a warning,
consistent with the warning when variable names given are undefined.

I don't want to see either compact or extract deprecated because I do use
both (as do countless open source systems) and I don't think there is a
reasonable justification for deprecating them. The behaviour of these
functions is understood by static analysis tools, the alternatives are more
verbose and more prone to developer error / mistakes from typos. I do agree
with upping the error level in compact() from E_WARNING to E_ERROR and
upping the warning on bad parameter types to a TypeError (which is what I'd
originally pushed for), but I think these things should be a change to
compact specifically, separate from any other RFC.

-Dave

--000000000000ba5865060b503864--