Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:121855
MIME-Version: 1.0
References: <6566989F.7010305@adviesenzo.nl> <34dada8e-7f2a-4d94-b7df-d9d3c7b2f3ce@app.fastmail.com>
 <F200E6CF-5116-4361-AB5C-CDD67F2E2021@koalephant.com> <CAPzBOBPLK3rQwqYsfgF3nS6=nT1qTdz-pzVpgNFRmXd7Jh9oSA@mail.gmail.com>
 <CANLbj-rMjuj2trw7szowOgYA2+dB9m1a+xf0i4QiC-J+=BNeDw@mail.gmail.com>
In-Reply-To: <CANLbj-rMjuj2trw7szowOgYA2+dB9m1a+xf0i4QiC-J+=BNeDw@mail.gmail.com>
Date: Wed, 29 Nov 2023 10:02:20 +0100
Message-ID: <CAPzBOBMeB7XLW1fRoaGKmv3Re+rDJJOthPVoWU_Mi4dE3xcyNA@mail.gmail.com>
Cc: php internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] What is the prevailing sentiment about extract() and
 compact() ?
From: landers.robert@gmail.com (Robert Landers)

Robert Landers
Software Engineer
Utrecht NL

On Wed, Nov 29, 2023 at 9:36=E2=80=AFAM Ayesh Karunaratne <ayesh@php.watch>=
 wrote:
>
> >
> > try {
> >   // do stuff
> > } catch(Throwable $exception) {
> >   $this->logger->error("failed to do stuff", compact('exception'));
> >   throw $exception;
> > }
> >
>
> I wonder why not just create an array with the key...
>
> ```php
> try {
>    // do stuff
> } catch(Throwable $exception) {
>    $this->logger->error("failed to do stuff", ['exception' =3D> $exceptio=
n]));
>    throw $exception;
> }
> ```
>
> It's a few more characters of course, but I would pick the readability
> and simplicity over the potential typos (which the IDE should point
> out) and a few key presses it saves.I

Hey Ayesh,

Yeah, this is very much a personal preference kind of thing. I choose
compact not because it is shorter to type, but because typos are a
thing if you've been around PHP for awhile... who hasn't opened a
function written 15 years ago with a misspelled variable that you want
to fix but it has been that way for 15 years, so you don't fix it.

I've also used compact inside array_maps like:

$arr =3D array_map(function($a) {
  $name =3D $a['first'] . " " . $a['last'];
  // more mappings
  return compact('name', ...);
}, $arr);

just because it is easier to type/read than a bunch of array accesses.
Possibly faster as well, but if it is, it's by nano-seconds.

Robert Landers
Software Engineer
Utrecht NL