Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:121853
MIME-Version: 1.0
References: <6566989F.7010305@adviesenzo.nl> <34dada8e-7f2a-4d94-b7df-d9d3c7b2f3ce@app.fastmail.com>
 <F200E6CF-5116-4361-AB5C-CDD67F2E2021@koalephant.com> <CAPzBOBPLK3rQwqYsfgF3nS6=nT1qTdz-pzVpgNFRmXd7Jh9oSA@mail.gmail.com>
In-Reply-To: <CAPzBOBPLK3rQwqYsfgF3nS6=nT1qTdz-pzVpgNFRmXd7Jh9oSA@mail.gmail.com>
Date: Wed, 29 Nov 2023 15:36:07 +0700
Message-ID: <CANLbj-rMjuj2trw7szowOgYA2+dB9m1a+xf0i4QiC-J+=BNeDw@mail.gmail.com>
To: Robert Landers <landers.robert@gmail.com>
Cc: Stephen Reay <php-lists@koalephant.com>, php internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [PHP-DEV] What is the prevailing sentiment about extract() and
 compact() ?
From: ayesh@php.watch (Ayesh Karunaratne)

>
> try {
>   // do stuff
> } catch(Throwable $exception) {
>   $this->logger->error("failed to do stuff", compact('exception'));
>   throw $exception;
> }
>

I wonder why not just create an array with the key...

```php
try {
   // do stuff
} catch(Throwable $exception) {
   $this->logger->error("failed to do stuff", ['exception' => $exception]));
   throw $exception;
}
```

It's a few more characters of course, but I would pick the readability
and simplicity over the potential typos (which the IDE should point
out) and a few key presses it saves.I