Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:121720
MIME-Version: 1.0
References: <CAH5C8xX5Wzbm1eerFJJ5hCZdUU8rci8NhBwkSwprRKAG531G7Q@mail.gmail.com>
 <CAEKnhAFDYiPoKwjj2J6akEaZ6WgHkaYia9su_fNQGSKidCt=aw@mail.gmail.com>
In-Reply-To: <CAEKnhAFDYiPoKwjj2J6akEaZ6WgHkaYia9su_fNQGSKidCt=aw@mail.gmail.com>
Date: Mon, 20 Nov 2023 05:16:57 +0100
Message-ID: <CAGKNXQHnvNKKXBMNTKq5KbuskJ5OtaSejEU6VRDgn5ngKtSprA@mail.gmail.com>
To: Jakub Zelenka <bukka@php.net>
Cc: =?UTF-8?B?TcOhdMOpIEtvY3Npcw==?= <kocsismate90@gmail.com>, 
	PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000006a27ab060a8dc2b9"
Subject: Re: [PHP-DEV] [RFC] [Discussion] Resource to object conversion
From: phofstetter@sensational.ch (Philip Hofstetter)

--0000000000006a27ab060a8dc2b9
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi,


On Thu, Nov 16, 2023 at 17:14 Jakub Zelenka <bukka@php.net> wrote:

> I will personally vote against this if there is no is_resource
> change as I think it's just too big BC break even for 9.0 - it will likel=
y
> require massive update of many code bases.


As someone maintaining a large code-base going back to 5.0.0 and bitten in
the past by the resource thing, I wonder whether it was previously
discussed to have all these converted objects implement a `Resource`
interface and have `is_resource()` check for that.

Both the function and maybe also the interface could then also be marked as
deprecated, but it would allow for a much more painless transition.

Personally, I=E2=80=99m now relying on psalm to detect such issues, so if I=
 had a
vote I would selfishly vote yes anyways, but still: for those without
static analysis, this would IMHO make things much easier.

Philip

--0000000000006a27ab060a8dc2b9--