Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:121710
Date: Fri, 17 Nov 2023 18:13:16 +0100 (GMT+01:00)
To: internals@lists.php.net
Message-ID: <7bd0952c-3105-47bd-87e9-ab6f68f540b6@daniil.it>
MIME-Version: 1.0
Content-Type: multipart/alternative; 
	boundary="----=_Part_3_48760707.1700241196679"
Subject: Report fatal error if JIT cannot be enabled due to a
 misconfiguration
From: daniil@daniil.it

------=_Part_3_48760707.1700241196679
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

Hi all,
Just a heads up as asked by Ilya, regarding https://github.com/php/php-src/pull/12403: this PR will improve the JIT startup logic by actually emitting a fatal error preventing PHP startup in case of a misconfiguration or other JIT-related issues.

The fatal errors will explain the exact reason why JIT startup failed, obviously if and only if JIT is explicitly enabled in the configuration (which it isn't, by default).

I feel this is a distinct improvement over the current implementation which just silently disables JIT, with no logs whatsoever, to the point where the only way of finding out that JIT is not enabled even if you did enable it in the config is running opcache_get_status.

Hope it's all fine by you, planning to get this merged by PHP 8.4.

Regards,
Daniil Gentili.

------=_Part_3_48760707.1700241196679--