Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:121692
MIME-Version: 1.0
References: <CAPTD5yFw3o_dnCzEF+BT3MJNGGtGMDJS35uqzsHq3OX0uGeF9w@mail.gmail.com>
 <CAFMT4NpdD7N04UCkLeEJiH=NtSGMDjBAGzDccyycXfuWMRNEaA@mail.gmail.com>
In-Reply-To: <CAFMT4NpdD7N04UCkLeEJiH=NtSGMDjBAGzDccyycXfuWMRNEaA@mail.gmail.com>
Date: Thu, 16 Nov 2023 00:12:38 +0000
Message-ID: <CAFPFaMJS8aYR0PtXS5EnJ0roT8z8bHSe5AshRFxP=E2xowbaAA@mail.gmail.com>
To: Levi Morrison <levim@php.net>
Cc: Jorg Sowa <jorg.sowa@gmail.com>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000004e3966060a39e1b6"
Subject: Re: [PHP-DEV] [RFC] [VOTE] Add 4 new rounding modes to round() function
From: george.banyard@gmail.com ("G. P. B.")

--0000000000004e3966060a39e1b6
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, 15 Nov 2023 at 23:43, Levi Morrison <levim@php.net> wrote:

> On Wed, Nov 15, 2023 at 2:26=E2=80=AFPM Jorg Sowa <jorg.sowa@gmail.com> w=
rote:
> >
> > Hello internals!
> > I have just opened voting on the RFC to add 4 new rounding modes to
> round()
> > function.
> >
> > Voting will end November 30th, 00:00 GMT.
> >
> > Link:
> > https://wiki.php.net/rfc/new_rounding_modes_to_round_function
> >
> > I'm sorry for previous message, but completely missed the title of the
> > message.
> >
> > Kind regards,
> > Jorg
>
> I didn't pay attention to the discussion. Sorry.
>
> I object to changing the intl code to add aliases. The intl extension
> is a wrapper around ICU, and I don't think it's a wise choice to
> modify it because you think "ROUND_TOWARD_ZERO" is better than
> "ROUND_DOWN". I agree the name is better, but that's not really how
> extension maintenance should work. I definitely don't think we should
> then _deprecate_ the ROUND_DOWN/ROUND_UP constants in ICU, given that
> the extension itself hasn't deprecated them and is still maintained. I
> am surprised nobody pointed this out before.
>
> I don't have any objection to the rounding modes themselves.
>

Personally I am fine with adding aliases to ext/intl, it is not because the
extension is a wrapper that we can't enhance it to be somewhat consistent.
However, I do agree that deprecating the existing constants is a bad idea.
But the RFC vote, as far as I can understand, is not about deprecating it
in this release.

Best regards,

Gina P. Banyard

--0000000000004e3966060a39e1b6--