Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:121667
MIME-Version: 1.0
References: <CAB-BujYUueXGAi+Mz1xjmy_AWGJy2VLzf6_rk3_O1tqaEbQ92w@mail.gmail.com>
 <CA+p1FaYk4_M+cczv8yRvefyfNhpPfcYMrQGc1x+S1Ai7-x_j=g@mail.gmail.com>
 <CAB-Bujb8g+g7OL34hBy+6LtLDiH9aXdrkZo7KdnAxhMs1FNjsA@mail.gmail.com> <CAB-BujaOckOXFBrWF2DbBmwSEcp2Y-9vZu_c=uxnDQc5=Va0eA@mail.gmail.com>
In-Reply-To: <CAB-BujaOckOXFBrWF2DbBmwSEcp2Y-9vZu_c=uxnDQc5=Va0eA@mail.gmail.com>
Date: Tue, 14 Nov 2023 01:08:06 +0000
Message-ID: <CA+p1FabQXDf-KV22Um=FoM6aQA=e7+i3kuAUaYf5bgJDU05+sQ@mail.gmail.com>
To: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000fc8d8c060a126b79"
Subject: Re: [PHP-DEV] Array functions with strict comparison
From: davidgebler@gmail.com (David Gebler)

--000000000000fc8d8c060a126b79
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sun, Nov 12, 2023 at 8:20=E2=80=AFPM Andreas Hennings <andreas@dqxtech.n=
et>
wrote:

> So to me, this alone is an argument to implement this natively.
> The other argument is that it is kind of sad how the current functions
> don't behave as one would expect.


I'd expect there to be a larger and proportionately increasing performance
difference between array_diff versus array_udiff with callback or a
userland array_diff_strict function the larger the datasets you feed in.
But I'm not sure how common either the use case of diffing arrays of 25,000
or 250,000 elements might be, or needing this comparison to be strict
equality. I suspect the use case where both these conditions apply is very
rare.

But if you want to create an RFC, please go for it. You could add an extra
parameter to these functions after the input arrays, which was a flag for
strict comparison. Whether such a thing with a default value of non-strict
(so not BC breaking) would be considered preferable to new global
functions, I'm not sure. I'd probably go with new functions but maybe
someone else will weigh in with their thoughts.

--000000000000fc8d8c060a126b79--