Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:121655
Message-ID: <722a3c38-fa29-4cff-94e6-f965cec55a11@bastelstu.be>
Date: Sat, 11 Nov 2023 16:32:35 +0100
MIME-Version: 1.0
To: Niels Dossche <dossche.niels@gmail.com>,
 PHP internals <internals@lists.php.net>
References: <04ba672f-33e1-4aae-aac4-7ad55dbc21de@gmail.com>
Content-Language: en-US
In-Reply-To: <04ba672f-33e1-4aae-aac4-7ad55dbc21de@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] [RFC] [Discussion] Improve callbacks in ext/dom and
 ext/xsl
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=C3=BCsterhus?=)

Hi

On 11/7/23 20:32, Niels Dossche wrote:
> I'm opening the discussion for my RFC "Improve callbacks in ext/dom and ext/xsl".
> RFC link: https://wiki.php.net/rfc/improve_callbacks_dom_and_xsl

Some question that I believe are not answered:

1.

$xpath->registerPhpFunctions([
   "foo" => ...
]);

$xpath->registerPhpFunctions([
   "foo" => ...
]);

Is this an error due to the duplicate definition or will the last 'foo' win?

2.

$xpath->registerPhpFunctions([]);

Is this an error or a noop?

3.

Would it make sense to deprecate passing a string as "Future Scope"? 
Simplifying the method signature would also allow to simplify the 
documentation in the long run and registering a string is trivially 
fixed by adding square brackets.

In fact looking at the existing documentation at 
https://www.php.net/manual/en/domxpath.registerphpfunctions.php, what's 
the difference between 'php:function()' and 'php:functionString()'?

Best regards
Tim Düsterhus