Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:121636
MIME-Version: 1.0
References: <CAFv4g+EqzB7whakuN-sr6YL2ih9xhHPzCsvTsEgJKMXBh9H9wQ@mail.gmail.com>
 <5144806E-E21F-4AF8-B9A2-0161561A6B9E@craigfrancis.co.uk> <CAGBsUrfwRExOFZ8dRy0=D9wmKurkj4QBNPvOsmrw7Mh=rjX0mg@mail.gmail.com>
 <1A044D32-019A-4152-A3C0-3F393974AC3B@craigfrancis.co.uk> <CABigaAXMapTU_DKNq-Jz1Mo+NM01EVZjjaUG+9oa9bxxeScq3A@mail.gmail.com>
 <88815C70-1100-442A-AFCC-A420862669C3@craigfrancis.co.uk>
In-Reply-To: <88815C70-1100-442A-AFCC-A420862669C3@craigfrancis.co.uk>
Reply-To: autaut03@gmail.com
Date: Fri, 10 Nov 2023 13:47:26 +0200
Message-ID: <CABigaAUPcCOE0MG+qa5+t4O5Fqm0_1Y4J67+NT_eKvJB-BwqWQ@mail.gmail.com>
To: Craig Francis <craig@craigfrancis.co.uk>
Cc: Kamil Tekiela <tekiela246@gmail.com>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000000d217b0609cae3b6"
Subject: Re: [PHP-DEV] Passing null to parameter
From: autaut03@gmail.com (Alex Wells)

--0000000000000d217b0609cae3b6
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Nov 10, 2023 at 1:33=E2=80=AFPM Craig Francis <craig@craigfrancis.c=
o.uk>
wrote:

> On 10 Nov 2023, at 10:54, Alex Wells <autaut03@gmail.com> wrote:
>
> PHPStan does find them:
> https://phpstan.org/r/38fc1545-2567-49b9-9937-f275dcfff6f5
>
>
>
> It does not:
>
> https://phpstan.org/r/c533ff42-80e4-4309-9751-1ec79e359946
>
>
It fails to correctly change the type of the variable to nullable due to
the coalescing operator. This is a bug in PHPStan, but if you manually
specify the type of that variable as nullable, it starts to correctly
report an error on line 5. So it's not that PHPStan can't find places where
a null is passed into a non-nullable parameter, but rather PHPStan failing
to infer the variable type correctly, thinking it's actually not nullable.

--0000000000000d217b0609cae3b6--