Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:121620
MIME-Version: 1.0
References: <CAMGiJ1-hwC18jA51a0NZbUeVR8EMvV65omzw6WsQ9Q1UPJgO=Q@mail.gmail.com>
 <CADU7aosgPn87AsEFokpTQJe7veX8z2uV4wbC6-s-G6jvZHFHpw@mail.gmail.com> <0fde7cd8-3913-4552-b67b-9c3670f5a2e6@beccati.com>
In-Reply-To: <0fde7cd8-3913-4552-b67b-9c3670f5a2e6@beccati.com>
Reply-To: Thomas Chauchefoin <thomas.chauchefoin@sonarsource.com>
Date: Wed, 8 Nov 2023 17:58:42 +0100
Message-ID: <CAMGiJ1_p=HQ_5y7St5hAS8+aBfPAVfhYoX_wfnwwy=z=6QV2hA@mail.gmail.com>
To: internals@lists.php.net
Cc: Matteo Beccati <matteo@beccati.com>, sebastian@php.net, george.banyard@gmail.com, 
	kevin@dunglas.fr
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Set register_argc_argv to Off by default
From: internals@lists.php.net ("Thomas Chauchefoin via internals")

On Tue, Nov 7, 2023 at 11:46=E2=80=AFAM Sebastian Bergmann <sebastian@php.n=
et> wrote:
> Am 07.11.2023 um 11:33 schrieb Thomas Chauchefoin via internals:
> > For instance, the official Docker image has it on [2].
>
> "Official" is relative here. That image is maintained by (the) Docker
> (community), it is not maintained by the PHP project.

Indeed, my bad. I've updated the GitHub issue to reflect that this
Docker image is not maintained by the PHP project.

On Tue, Nov 7, 2023 at 2:12=E2=80=AFPM K=C3=A9vin Dunglas <kevin@dunglas.fr=
> wrote:
> This change seems reasonable to me: safer, with little chance of breaking
> things, and easy to reverse for the end user by changing a single paramet=
er.

On Tue, Nov 7, 2023 at 5:33=E2=80=AFPM Matteo Beccati <matteo@beccati.com> =
wrote:
> Seriously though, I do agree with changing the default. I believe such
> check was added in a time when it was still common to use the cgi
> executable to run cli commands and the configuration was shared with
> mod_php.

On Tue, Nov 7, 2023 at 4:48=E2=80=AFPM G. P. B. <george.banyard@gmail.com> =
wrote:
> This sounds sensible to me.

Thank you for your early feedback on this suggestion. Without rushing
things, I assume that the next step for me would be to draft an RFC to
formalize this change?

Best,
-Thomas