Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:121615
Return-Path: <saki@sakiot.com>
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 60885 invoked from network); 8 Nov 2023 02:25:21 -0000
Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5)
  by pb1.pair.com with SMTP; 8 Nov 2023 02:25:21 -0000
Received: from php-smtp4.php.net (localhost [127.0.0.1])
	by php-smtp4.php.net (Postfix) with ESMTP id 301D81804D0
	for <internals@lists.php.net>; Tue,  7 Nov 2023 18:25:21 -0800 (PST)
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE,
	SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
	version=3.4.2
X-Spam-ASN: AS9370 160.16.128.0/17
X-Spam-Virus: No
X-Envelope-From: <saki@sakiot.com>
Received: from mail.sakiot.com (mail.sakiot.com [160.16.227.216])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256)
	(No client certificate requested)
	by php-smtp4.php.net (Postfix) with ESMTPS
	for <internals@lists.php.net>; Tue,  7 Nov 2023 18:25:20 -0800 (PST)
Received: from smtpclient.apple (55.150.159.133.rev.vmobile.jp [133.159.150.55])
	(using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))
	(No client certificate requested)
	by mail.sakiot.com (Postfix) with ESMTPSA id 668F4401D2;
	Wed,  8 Nov 2023 11:25:19 +0900 (JST)
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0 (1.0)
Date: Wed, 8 Nov 2023 11:25:07 +0900
Message-ID: <8B3F90CB-31B6-4D07-A8E4-E93BBA8999F4@sakiot.com>
References: <65ef661f-9fab-494a-9885-0a07c78c17cf@wikimedia.org>
Cc: internals@lists.php.net
In-Reply-To: <65ef661f-9fab-494a-9885-0a07c78c17cf@wikimedia.org>
To: Tim Starling <tstarling@wikimedia.org>
X-Mailer: iPhone Mail (21A360)
Subject: Re: [PHP-DEV] [RFC] [Discussion] Change the edge case of round()
From: saki@sakiot.com (Saki Takamachi)

Hi Tim,

> I think, most often, round() is done on the result of some calculation, no=
t on decimal literals. The previous implementation seems to prioritize round=
ing of decimal literals over correct rounding of the actual value.

Yes, as Jakub pointed out, there was a lack of explanation regarding existin=
g implementations. I would like to add it to the RFC.

Regards.

Saki=