Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:121587
Feedback-ID: i6f4c46c2:Fastmail
Message-ID: <129fb16f-8d38-4951-b84d-f25799158e2b@beccati.com>
Date: Sun, 5 Nov 2023 13:31:53 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Content-Language: it
To: Saki Takamachi <saki@sakiot.com>
References: <734FB3C6-EBE6-4F35-8738-436AF7D8B161@sakiot.com>
Cc: PHP internals <internals@lists.php.net>
In-Reply-To: <734FB3C6-EBE6-4F35-8738-436AF7D8B161@sakiot.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Fix the inconsistent behavior of PDO::PARAM_XXX
From: php@beccati.com (Matteo Beccati)

Hi Saki,

Il 04/11/2023 07:59, Saki Takamachi ha scritto:
> Hi internals,
> 
> As shown in the following issue, the behavior of `PDO::PARAM_XXXX` is inconsistent and I would like to fix this.
> https://github.com/php/php-src/issues/12603
> 
> First, I tried fixed pdo_pgsql.
> https://github.com/php/php-src/pull/12605
> 
> Eventually I plan to make similar changes to all bundled pdos.
> 
> What do you think about these? If there is a reason for the current implementation that should not be changed, it would be very helpful if you could tell me why.

I'm sure there are several bugs w/ types in PDO.

Perhaps some can be fixed, but I would be very careful touching that part.

The last time I tried to fix the PDO_PARAM_INT behaviour on pdo_pgsql I 
broke Laravel and surely many other projects.

I'm afraid that most libraries and projects have now worked around some 
of the bugs and trying to fix them is going to cause BC problems, or 
generate a whole new series of bugs and incompatibilities.

See:

https://bugs.php.net/bug.php?id=80892
https://github.com/php/php-src/pull/6801


Cheers
-- 
Matteo Beccati

Development & Consulting - http://www.beccati.com/