Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:121575
Content-Type: multipart/alternative; boundary=Apple-Mail-C96AC14F-C559-4834-AA10-08533AE68E09
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0 (1.0)
Date: Sat, 4 Nov 2023 15:59:24 +0900
Message-ID: <734FB3C6-EBE6-4F35-8738-436AF7D8B161@sakiot.com>
To: PHP internals <internals@lists.php.net>
Subject: Fix the inconsistent behavior of PDO::PARAM_XXX
From: saki@sakiot.com (Saki Takamachi)

--Apple-Mail-C96AC14F-C559-4834-AA10-08533AE68E09
Content-Type: text/plain;
	charset=us-ascii
Content-Transfer-Encoding: quoted-printable

Hi internals,

As shown in the following issue, the behavior of `PDO::PARAM_XXXX` is incons=
istent and I would like to fix this.
https://github.com/php/php-src/issues/12603

First, I tried fixed pdo_pgsql.
https://github.com/php/php-src/pull/12605

Eventually I plan to make similar changes to all bundled pdos.

What do you think about these? If there is a reason for the current implemen=
tation that should not be changed, it would be very helpful if you could tel=
l me why.

Also, if an RFC is required, it would be helpful if you could point it out a=
s well. Personally, I don't think an RFC is necessary since this is some kin=
d of bug fix. However, I believe the target should be the master branch as i=
t changes the user experience somewhat.

[*] I'm not thinking about LOB here, but once I leave them with their existi=
ng behavior, I change the behavior of other types. Because LOB have complex b=
ehavior, the scope becomes too large. After making this change, I will test a=
gain and post another issue if necessary.

[*] I would like the type of PARAM_BOOL to be exactly bool, but this would a=
lso require changing the behavior of the emulator, and I would not be able t=
o issue a PR for each driver, making the scope too large. For this as well, I=
 will just align it to `int(1)` or `string(1) 't'`, etc., and once these cha=
nges are completed, I will verify it and post an issue.

[*] odbc etc. are not compatible with emulation in the first place. There ar=
e no plans to change this in this context.

Regards.

Saki

--Apple-Mail-C96AC14F-C559-4834-AA10-08533AE68E09--