Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:12150 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 7968 invoked by uid 1010); 13 Aug 2004 10:54:41 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 7056 invoked from network); 13 Aug 2004 10:54:31 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by pb1.pair.com with SMTP; 13 Aug 2004 10:54:31 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i7DAsUe1002767 for ; Fri, 13 Aug 2004 06:54:30 -0400 Received: from radish.cambridge.redhat.com (radish.cambridge.redhat.com [172.16.18.90]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i7DAsUa22712 for ; Fri, 13 Aug 2004 06:54:30 -0400 Received: from radish.cambridge.redhat.com (localhost.localdomain [127.0.0.1]) by radish.cambridge.redhat.com (8.12.10/8.12.7) with ESMTP id i7DAsSHP017611 for ; Fri, 13 Aug 2004 11:54:28 +0100 Received: (from jorton@localhost) by radish.cambridge.redhat.com (8.12.10/8.12.10/Submit) id i7DAsSrP017610 for internals@lists.php.net; Fri, 13 Aug 2004 11:54:28 +0100 Date: Fri, 13 Aug 2004 11:54:28 +0100 To: internals@lists.php.net Message-ID: <20040813105428.GA17584@redhat.com> Mail-Followup-To: internals@lists.php.net References: <20040813104646.GA17569@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20040813104646.GA17569@redhat.com> User-Agent: Mutt/1.4.1i Subject: Re: [PATCH] apache2handler config.m4 update From: jorton@redhat.com (Joe Orton) On Fri, Aug 13, 2004 at 11:46:46AM +0100, Joe Orton wrote: > This fixes the apache2handler build against HEAD of httpd-2.0: Actually, this alternative patch is a fractionally safer change, avoiding picking up --cflags from apr-config: Index: sapi/apache2handler/config.m4 =================================================================== RCS file: /repository/php-src/sapi/apache2handler/config.m4,v retrieving revision 1.9 diff -u -r1.9 config.m4 --- sapi/apache2handler/config.m4 21 Oct 2003 11:48:31 -0000 1.9 +++ sapi/apache2handler/config.m4 13 Aug 2004 10:50:30 -0000 @@ -39,8 +39,14 @@ APU_BINDIR=`$APXS -q APU_BINDIR` APR_BINDIR=`$APXS -q APR_BINDIR` - APU_INCLUDEDIR="`$APU_BINDIR/apu-config --includes`" - APR_INCLUDEDIR="`$APR_BINDIR/apr-config --includes`" + # Pick up ap[ru]-N-config if using httpd >=2.1 + APR_CONFIG=`$APXS -q APR_CONFIG 2>/dev/null` || + APR_CONFIG="$APR_BINDIR/apr-config" + APU_CONFIG=`$APXS -q APU_CONFIG 2>/dev/null` || + APU_CONFIG="$APU_BINDIR/apu-config" + + APR_CFLAGS="`$APR_CONFIG --cppflags --includes`" + APU_CFLAGS="`$APU_CONFIG --includes`" for flag in $APXS_CFLAGS; do case $flag in @@ -48,7 +54,7 @@ esac done - APACHE_CFLAGS="$APACHE_CPPFLAGS -I$APXS_INCLUDEDIR $APU_INCLUDEDIR $APR_INCLUDEDIR" + APACHE_CFLAGS="$APACHE_CPPFLAGS -I$APXS_INCLUDEDIR $APR_CFLAGS $APU_CFLAGS" # Test that we're trying to configure with apache 2.x PHP_AP_EXTRACT_VERSION($APXS_HTTPD)