Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:121407
Feedback-ID: i8414410d:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-1019-ged83ad8595-fm-20231002.001-ged83ad85
MIME-Version: 1.0
Message-ID: <dd5d5568-f905-4523-b103-c92215a73d2a@app.fastmail.com>
In-Reply-To: 
 <CAPzBOBNve49sjZ6O5PF50zwLQLBLEOBjVkTDiW5pY552HU6uHQ@mail.gmail.com>
References: <b8fabda9-cd9f-46a7-a8d6-9de0e30f4910@daniil.it>
 <a0c6373b-9a17-4c9b-8f37-8ee2c7e2bb30@bastelstu.be>
 <CAPzBOBNve49sjZ6O5PF50zwLQLBLEOBjVkTDiW5pY552HU6uHQ@mail.gmail.com>
Date: Wed, 18 Oct 2023 16:32:36 +0000
To: "php internals" <internals@lists.php.net>
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Final anonymous classes
From: larry@garfieldtech.com ("Larry Garfield")

On Wed, Oct 18, 2023, at 12:35 PM, Robert Landers wrote:
> On Wed, Oct 18, 2023 at 2:26=E2=80=AFPM Tim D=C3=BCsterhus <tim@bastel=
stu.be> wrote:
>>
>> Hi
>>
>> On 10/17/23 19:06, Daniil Gentili wrote:
>> > Personally, I would have instead preferred the much cleaner approac=
h of
>> > making *all* anonymous classes final by default, (preferrably) with=
out
>> > offering the option to make them non-final.
>> >
>> > However, I understand that this might be a little bit too restricti=
ve
>> > for something that may have some valid usecases, even if extending
>> > anonymous classes currently requires some hack-ish workarounds with
>> > class_alias.
>> >
>
> Hello,
>
>> Perhaps make it two votes, each requiring a 2/3 majority?
>>
>> 1. Allow the 'final' keyword on anonymous classes?
>> 2. Enforce that all anonymous classes are final?
>
> How would someone make an anonymous class "unfinal"? I've used this
> "hack" in unit tests, many times. It's quite useful, so this would
> probably break a number of (at least my) unit tests if (2) were
> chosen.

Making anon classes final by default would necessitate a new keyword to =
de-final them; `open` comes to mind as that's what Kotlin uses for that =
purpose, but there are other options to bikeshed.

I... don't even know how to extend an anon class, honestly, so I'm prett=
y sure the impact of going all the way would be small.  I'm currently un=
decided on which I prefer, but at least allowing them to be final sounds=
 reasonable.

One thing I'm not sure about: What opcache optimizations would final ena=
ble? =20

--Larry Garfield