Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:121402
MIME-Version: 1.0
References: <173ca550-71a0-4bd4-96f2-b64b6155115a@app.fastmail.com>
 <CBB83C7D-B10F-410E-B879-F2FA9EDB2F65@sakiot.com> <CAB_ngDi2bEWYxWF+XMmGHXty5hH44=DepdisOQX9hcGLmz0w9A@mail.gmail.com>
 <CADK1yXLJWo7NJdBGVbtGEeDjRfc1f1LbftgdoP3co_D6d8nz5w@mail.gmail.com>
 <CAPzBOBO=_WODT0HC0uaJ3OvqxD4YuMXqL5a-4tiH+MZAk1TUNQ@mail.gmail.com>
 <CADK1yXLNz9Qugut4i723TyEbhO0ntWXac=kaUKMMo_a+0piaGQ@mail.gmail.com>
 <CAPzBOBOUGcRVAV6hUa8uDFgOXGLChAwRv-ga5R1-cnD39cXEpg@mail.gmail.com>
 <CADK1yXJbT_r0B0d6-Xiet7MYpphdk7FuFqtvo23K6WcmVZ4EzA@mail.gmail.com>
 <CAPzBOBMvGj5JKdvf_xvLZ+f48rbWxAaWOydDKDdbjuCoH1s8zg@mail.gmail.com> <CAG9XoMTKDCa2d683mkXMC3XNK866-AsMzemxPdmRQU36NjsfaA@mail.gmail.com>
In-Reply-To: <CAG9XoMTKDCa2d683mkXMC3XNK866-AsMzemxPdmRQU36NjsfaA@mail.gmail.com>
Reply-To: Levi Morrison <levi.morrison@datadoghq.com>
Date: Wed, 18 Oct 2023 17:47:02 +0200
Message-ID: <CAAKU0u=+SvDRukFeEadGWJLr=pO7nsmEpWUZ_J=B688uNN9QBQ@mail.gmail.com>
To: Benjamin Morel <benjamin.morel@gmail.com>
Cc: Robert Landers <landers.robert@gmail.com>, Deleu <deleugyn@gmail.com>, 
	Brandon Jackson <brandonja991@gmail.com>, Saki Takamachi <saki@sakiot.com>, 
	Levi Morrison via internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [PHP-DEV] Two new functions array_first() and array_last()
From: internals@lists.php.net ("Levi Morrison via internals")

> > This is simply not true, 0 is not always the first key in a list,
> > especially after filtering it. Hence there is a need for this function
> > in the first place.
>
> Just to clarify this point: If 0 is not the first key, then it's not a list.
> After filtering a list, you get an array that may or may not be a list:
> https://3v4l.org/VegUr

I don't see how `array_is_list` is relevant to `array_first` and
`array_last`. PHP arrays are ordered:

    $foo = [
        "first" => 1,
        "third" => 3,
    ];

It would be perfectly fine to use `array_first` or `array_last` with
`$foo`. I think probably you would use `array_key_first` and
`array_key_last` so you also get the key and not just the value, but I
don't see any need to reduce `array_first` and `array_last` to only be
logical or correct with arrays that uphold `array_is_list`.