Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:121398
MIME-Version: 1.0
References: <173ca550-71a0-4bd4-96f2-b64b6155115a@app.fastmail.com>
 <CBB83C7D-B10F-410E-B879-F2FA9EDB2F65@sakiot.com> <CAB_ngDi2bEWYxWF+XMmGHXty5hH44=DepdisOQX9hcGLmz0w9A@mail.gmail.com>
 <CADK1yXLJWo7NJdBGVbtGEeDjRfc1f1LbftgdoP3co_D6d8nz5w@mail.gmail.com>
 <CAPzBOBO=_WODT0HC0uaJ3OvqxD4YuMXqL5a-4tiH+MZAk1TUNQ@mail.gmail.com>
 <CADK1yXLNz9Qugut4i723TyEbhO0ntWXac=kaUKMMo_a+0piaGQ@mail.gmail.com>
 <CAPzBOBOUGcRVAV6hUa8uDFgOXGLChAwRv-ga5R1-cnD39cXEpg@mail.gmail.com>
 <CADK1yXJbT_r0B0d6-Xiet7MYpphdk7FuFqtvo23K6WcmVZ4EzA@mail.gmail.com> <CAPzBOBMvGj5JKdvf_xvLZ+f48rbWxAaWOydDKDdbjuCoH1s8zg@mail.gmail.com>
In-Reply-To: <CAPzBOBMvGj5JKdvf_xvLZ+f48rbWxAaWOydDKDdbjuCoH1s8zg@mail.gmail.com>
Date: Wed, 18 Oct 2023 17:28:42 +0200
Message-ID: <CAG9XoMTKDCa2d683mkXMC3XNK866-AsMzemxPdmRQU36NjsfaA@mail.gmail.com>
To: Robert Landers <landers.robert@gmail.com>
Cc: Deleu <deleugyn@gmail.com>, Brandon Jackson <brandonja991@gmail.com>, 
	Saki Takamachi <saki@sakiot.com>, Levi Morrison via internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000050cf60607ff4c10"
Subject: Re: [PHP-DEV] Two new functions array_first() and array_last()
From: benjamin.morel@gmail.com (Benjamin Morel)

--000000000000050cf60607ff4c10
Content-Type: text/plain; charset="UTF-8"

On Wed, 18 Oct 2023 at 17:05, Robert Landers <landers.robert@gmail.com>
wrote:

>
> This is simply not true, 0 is not always the first key in a list,
> especially after filtering it. Hence there is a need for this function
> in the first place.


Just to clarify this point: If 0 is not the first key, then it's not a list.
After filtering a list, you get an array that may or may not be a list:
https://3v4l.org/VegUr


Regardless, to add my 2 cents, I'd keep things simple and vote for this
signature:

array_first(array $array): mixed
array_last(array $array): mixed

returning the first/last element, or `null` if the array is empty.


Or, alternatively:

array_first(array $array, mixed $default = null): mixed
array_last(array $array, mixed $default = null): mixed

returning `$default` if the array is empty.
Both look fine to me.

- Benjamin

--000000000000050cf60607ff4c10--