Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:121397
MIME-Version: 1.0
References: <173ca550-71a0-4bd4-96f2-b64b6155115a@app.fastmail.com>
 <CBB83C7D-B10F-410E-B879-F2FA9EDB2F65@sakiot.com> <CAB_ngDi2bEWYxWF+XMmGHXty5hH44=DepdisOQX9hcGLmz0w9A@mail.gmail.com>
 <CADK1yXLJWo7NJdBGVbtGEeDjRfc1f1LbftgdoP3co_D6d8nz5w@mail.gmail.com>
 <CAPzBOBO=_WODT0HC0uaJ3OvqxD4YuMXqL5a-4tiH+MZAk1TUNQ@mail.gmail.com>
 <CADK1yXLNz9Qugut4i723TyEbhO0ntWXac=kaUKMMo_a+0piaGQ@mail.gmail.com>
 <CAPzBOBOUGcRVAV6hUa8uDFgOXGLChAwRv-ga5R1-cnD39cXEpg@mail.gmail.com> <CADK1yXJbT_r0B0d6-Xiet7MYpphdk7FuFqtvo23K6WcmVZ4EzA@mail.gmail.com>
In-Reply-To: <CADK1yXJbT_r0B0d6-Xiet7MYpphdk7FuFqtvo23K6WcmVZ4EzA@mail.gmail.com>
Date: Wed, 18 Oct 2023 17:04:38 +0200
Message-ID: <CAPzBOBMvGj5JKdvf_xvLZ+f48rbWxAaWOydDKDdbjuCoH1s8zg@mail.gmail.com>
To: Deleu <deleugyn@gmail.com>
Cc: Brandon Jackson <brandonja991@gmail.com>, Saki Takamachi <saki@sakiot.com>, 
	Levi Morrison via internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Two new functions array_first() and array_last()
From: landers.robert@gmail.com (Robert Landers)

> I completely understand what you're saying and I don't disagree with the =
thought process. What I disagree with is your statement that you will alway=
s use array_first() together with array_key_first(). When talking about sta=
ndard lists (indexed from 0 to upper-bound), array_first() is an order of m=
agnitude more useful than array_key_first() as we always know what the firs=
t key is: 0.

This is simply not true, 0 is not always the first key in a list,
especially after filtering it. Hence there is a need for this function
in the first place.

> Here's another thought process: suppose PHP never gets array_first(). In =
your Fiber scenarios, you need to use `array_key_first()` and `$array[array=
_key_first()]` and deal with any edge cases around this. You have found iss=
ues, dealt with it and you're now aware of them. It's really nice that you =
want to avoid others from going through the same pain as you did, but the f=
act is `array_first()` or `$array[0]` is not only ALWAYS used together with=
 needing to know the key or not ALWAYS used with Fibers.

PHP chose to implement Fibers in this way and it should be cognizant
of them when implementing new features. That's all I'm saying. Whether
anyone who matters, actually cares, is another story. All I can do is
say something. You can only lead a horse to water, after all, you
can't force it to drink.

> What I'm saying is: don't force a design functionality only for your use =
case, especially as basic and fundamental as PHP Arrays. I don't want to be=
 forced to write `[$value, $_] =3D array_first()` just because there's a co=
rner of PHP functionality that needs special treatment. If this was fibers_=
array_first() I wouldn't mind at all.

If we went with the array return scenario:

// assuming it is in [value, key] form
[$value] =3D array_first($arr);
[,$key] =3D array_first($arr);
[$value, $key] =3D array_first($arr);

Or with the approach I suggested:
$value =3D array_first($arr);
array_first($arr, $key);
$value =3D array_first($arr, $key);

I don't think this is asking for much, nor complicated. Both
approaches seem simpler and less verbose than:

[$value, $key] =3D [array_first($arr), array_key_first($arr)];

At the end of the day, I'll be happy with any solution implemented,
because it is still far better than what we have currently.

Robert Landers
Software Engineer
Utrecht NL