Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:121384
MIME-Version: 1.0
References: <b8fabda9-cd9f-46a7-a8d6-9de0e30f4910@daniil.it> <a0c6373b-9a17-4c9b-8f37-8ee2c7e2bb30@bastelstu.be>
In-Reply-To: <a0c6373b-9a17-4c9b-8f37-8ee2c7e2bb30@bastelstu.be>
Date: Wed, 18 Oct 2023 14:35:28 +0200
Message-ID: <CAPzBOBNve49sjZ6O5PF50zwLQLBLEOBjVkTDiW5pY552HU6uHQ@mail.gmail.com>
To: =?UTF-8?Q?Tim_D=C3=BCsterhus?= <tim@bastelstu.be>
Cc: Daniil Gentili <daniil@daniil.it>, internals@lists.php.net
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Final anonymous classes
From: landers.robert@gmail.com (Robert Landers)

On Wed, Oct 18, 2023 at 2:26=E2=80=AFPM Tim D=C3=BCsterhus <tim@bastelstu.b=
e> wrote:
>
> Hi
>
> On 10/17/23 19:06, Daniil Gentili wrote:
> > Personally, I would have instead preferred the much cleaner approach of
> > making *all* anonymous classes final by default, (preferrably) without
> > offering the option to make them non-final.
> >
> > However, I understand that this might be a little bit too restrictive
> > for something that may have some valid usecases, even if extending
> > anonymous classes currently requires some hack-ish workarounds with
> > class_alias.
> >

Hello,

> Perhaps make it two votes, each requiring a 2/3 majority?
>
> 1. Allow the 'final' keyword on anonymous classes?
> 2. Enforce that all anonymous classes are final?

How would someone make an anonymous class "unfinal"? I've used this
"hack" in unit tests, many times. It's quite useful, so this would
probably break a number of (at least my) unit tests if (2) were
chosen.

Robert Landers
Software Engineer
Utrecht NL