Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:121347
MIME-Version: 1.0
References: <CAL-Ucw5Yu4ai-n6t=GdRX+DC+8a7_Z5Mw-pYN+jUtpZUGN7svg@mail.gmail.com>
 <CAAKU0umZoX0JGMuQiXZb2z6nqqNYDisncRj909Rp67g80Ab4NA@mail.gmail.com>
 <CAPzBOBNukh-AALa4mCPorDowFG7stmEfC-18DEXkVw6OYCj3EA@mail.gmail.com>
 <CANS-=peo7bm4eqU0m+vKBXGmpWBheXEUD-yQmAx8Dw48yzCgWg@mail.gmail.com>
 <CAPzBOBMQ7FF5zktLq3oQh5_9W7NvyaEj0n5SVQVpcevqjXSQHw@mail.gmail.com>
 <d58d6e84-9347-44d8-bfe7-923f76b7564f@alec.pl> <CAPzBOBMDCOwr=pquZSriU_gCj2vZ6ngq7c6sX6yOPR3B7CbiFQ@mail.gmail.com>
In-Reply-To: <CAPzBOBMDCOwr=pquZSriU_gCj2vZ6ngq7c6sX6yOPR3B7CbiFQ@mail.gmail.com>
Date: Tue, 17 Oct 2023 11:41:30 +0200
Message-ID: <CAPzBOBN_XmpfS8xXHoYFxEnM56KfZLcYOm4Ks-55KumA5Gx74w@mail.gmail.com>
To: Aleksander Machniak <alec@alec.pl>
Cc: internals@lists.php.net
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Two new functions array_first() and array_last()
From: landers.robert@gmail.com (Robert Landers)

On Tue, Oct 17, 2023 at 11:37=E2=80=AFAM Robert Landers
<landers.robert@gmail.com> wrote:
>
> On Tue, Oct 17, 2023 at 11:34=E2=80=AFAM Aleksander Machniak <alec@alec.p=
l> wrote:
> >
> > On 17.10.2023 11:29, Robert Landers wrote:
> > > $value =3D array_value_first($array, $key);
> > > if($key =3D=3D=3D null) // handle error
> > > else // do something with $value
> > >
> > > You can also freely ignore the key, if you don't need it or care abou=
t
> > > error checking. That would save doing two function calls on the same
> > > array, just to do some error checking.
> > >
> >
> > Please, no. What's wrong with count() or empty()?
> >
> > +1 for array_first() and array_last(). The only problem is probably a
> > big BC break. I myself have array_first() defined in my framework.
> >
> > --
> > Aleksander Machniak
> > Kolab Groupware Developer        [https://kolab.org]
> > Roundcube Webmail Developer  [https://roundcube.net]
> > ----------------------------------------------------
> > PGP: 19359DC1 # Blog: https://kolabian.wordpress.com
> >
> > --
> > PHP Internals - PHP Runtime Development Mailing List
> > To unsubscribe, visit: https://www.php.net/unsub.php
> >
>
> Hey Aleksander,
>
> > Please, no. What's wrong with count() or empty()?
>
> Nothing. Why not either one? You don't have to use the $key variable
> and you can use count() or empty(), but for me personally, it makes a
> lot of sense.

Ah, I just realized why it makes a lot of sense, and that is when
Fibers get involved. The value and key could change underneath you
from one function call to another.

$key =3D array_key_first($this-array);

// call something that suspends a fiber and results in $this->array
being mutated

$value =3D array_value_first($this->array);

// $value and $key may now point to two totally separate things.

I've been bitten by this with Fibers a few times now (or things very
similar to it).

Having a way to atomically get $key and $value would be a boon, not a hindr=
ance.

Robert Landers
Software Engineer
Utrecht NL