Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:121321
Content-Type: multipart/alternative;
 boundary="------------7Wp4xuKw7rx8fBqhVUQ5EHwd"
Message-ID: <055fd91e-743a-432c-a5ad-384a4b0f1f50@mabe.berlin>
Date: Sun, 15 Oct 2023 12:53:39 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Content-Language: en-US
To: internals@lists.php.net
References: <0e6ee882-472f-43e1-822e-c156d9048e0c@gmail.com>
 <75d8452e-23ad-4943-b5da-63fdc85c24a0@bastelstu.be>
 <6765d47f-7f6b-436e-b2c9-d98f675905b0@gmail.com>
In-Reply-To: <6765d47f-7f6b-436e-b2c9-d98f675905b0@gmail.com>
Subject: Re: [PHP-DEV] DOMXPath / XSLTProcessor function callbacks
From: marc@mabe.berlin (Marc)

--------------7Wp4xuKw7rx8fBqhVUQ5EHwd
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi,

On 14.10.23 13:54, Niels Dossche wrote:
> Hi Tim
>
> On 10/14/23 12:30, Tim Düsterhus wrote:
>> Hi
>>
>> On 10/13/23 00:39, Niels Dossche wrote:
>>> Please let me know your thoughts.
>> What does calling ->registerPHPFunctions() do when it's called more than once? Will the existing allow-list be overwritten or amended?
>>
>> i.e.
>>
>> $xpath->registerPHPFunctions([
>>    'strtoupper',
>> ]);
>> $xpath->registerPHPFunctions([
>>    'ucfirst',
>> ]);
>>
>> will I be able to:
>>
>> (a) Call ucfirst(), but not strtoupper()
>> (b) Call both
> You can call both, it's additive.

As it's not clear what these functions do wouldn't it make more sense to 
introduce new / more clear functions and deprecate the old?

Like:

->addXPathCallable(string $alias, callable $fn);
->getXPathCallables(): array<string, callable>
->removeXPathCallable(string $alias);

And is it really necessary to be able to register all functions? Also 
what would happen in this case with functions included later? Would they 
also be callable or only the functions known at the point of registering?

>> Best regards
>> Tim Düsterhus
> Cheers
> Niels


Best,
Marc

--------------7Wp4xuKw7rx8fBqhVUQ5EHwd--