Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:121317
MIME-Version: 1.0
References: <CAL-Ucw7H4zcbnhUJHHPi9=KX9NtPEVKiCOyNz+TTJfdwkzLRTw@mail.gmail.com>
In-Reply-To: <CAL-Ucw7H4zcbnhUJHHPi9=KX9NtPEVKiCOyNz+TTJfdwkzLRTw@mail.gmail.com>
Date: Sun, 15 Oct 2023 01:04:59 +0100
Message-ID: <CAO__Xv6bkphcxTR6R3p6VXAzhOwVC4NYe-7Vxxvvy-XSrT258A@mail.gmail.com>
To: David Grudl <david@grudl.com>
Cc: internals@lists.php.net
Content-Type: multipart/alternative; boundary="0000000000000a605f0607b60b42"
Subject: Re: [PHP-DEV] Better name for method Randomizer::nextFloat()
From: fenniclog@gmail.com (tag Knife)

--0000000000000a605f0607b60b42
Content-Type: text/plain; charset="UTF-8"

On Sat, 14 Oct 2023 at 18:48, David Grudl <david@grudl.com> wrote:

>
> A) The problem with nextFloat() is that the name creates a false
> expectation. Take a look at the following code:
> ```
> $randomizer = new \Random\Randomizer();
> $a = $randomizer->getFloat(100, 200); // number between 100..200
> $b = $randomizer->nextFloat(); // another number between 100..200 ???
> ```
>

I don't even get the point of  nextFloat. Its a random function, there is
no thing as "next".
I think the major pet peeve i have is that the "Randomizer" class is
encapsulating all random functions.
I would like to see each randomizer have its own class, since they are
under the Random namespace
anyway, I believe they should be Random/StringRandomizer,
Random/IntRandomizer,
Random/FloatRandomizer, so on so forth. Basically Ramdom/{Type}Randomizer.
This would
also allow more granular and specific functionality for each type.

For example, for this discussion, the class, Random/FloatRandomizer (and
IntRandomizer)
could be instatiated with its boundries.

```php
$randomFloat = new Random/FloatRandomizer($lowerBound, $upperBound,
$boundryInterval)
$a = $randomFloat->get();
$b = $randomFLoat->next();
```

Is that not more intuitive?

--0000000000000a605f0607b60b42--