Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:121302
MIME-Version: 1.0
References: <CAPyj-LD0EDYUZSOM=P9doSZRJ8LipSKKUSBHxV-bRbCV1QsYtQ@mail.gmail.com>
 <CAPyj-LD5=SDXmP5EhR-hfL-FreXXey-CGGoHcqEYq1z44YKRbA@mail.gmail.com>
In-Reply-To: <CAPyj-LD5=SDXmP5EhR-hfL-FreXXey-CGGoHcqEYq1z44YKRbA@mail.gmail.com>
Date: Fri, 13 Oct 2023 17:59:06 +0200
Message-ID: <CABdc3WpkWBFNao3A_+RQ9b-dXU74YivcwAaUu-yJ=Fmj1D4h0A@mail.gmail.com>
To: Ilija Tovilo <tovilo.ilija@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000789a7e06079b23a7"
Subject: Re: [PHP-DEV] Re: [RFC][Under discussion] RFC1867 for non-POST HTTP verbs
From: michal.brzuchalski@gmail.com (=?UTF-8?Q?Micha=C5=82_Marcin_Brzuchalski?=)

--000000000000789a7e06079b23a7
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Ilija,

pt., 13 pa=C5=BA 2023, 13:15 u=C5=BCytkownik Ilija Tovilo <tovilo.ilija@gma=
il.com>
napisa=C5=82:

> Hi everyone
>
> On Fri, Oct 6, 2023 at 3:44=E2=80=AFPM Ilija Tovilo <tovilo.ilija@gmail.c=
om>
> wrote:
> > https://wiki.php.net/rfc/rfc1867-non-post
>
> Thank you for the feedback so far. I made a handful of changes to the RFC=
.
>
> * The function is renamed to request_parse_body()
> * The function will now throw instead of emitting warnings when hitting
> limits
> * The Configuration section was added show how parsing limits may be
> modified per endpoint
> * The php://input is explained better in relation to multipart parsing
>
> Let me know if you have any more feedback.
>

Considering the function supports two formats multipart/form-data or
the application/x-www-form-urlencodedand
the fact that the return type and required arguments differ in regards to
format: content-type needed for multipart which returns two arrays packed
into return array aka $_POST and $_FILES and the boundary that is part of
content-type header and the other format that doesn't require content-type
header and returns effectively only one array aka $_POST why not having two
separate functions?

The proposal is to include two separate functions that have clear semantics
and prevent from invoking multipart without boundary or only form with
boundary:
* request_parse_body($input_stream): array - returning just $_POST
and maybe
* request_parse_multupart_body($input_stream, string $boundary): array
returning as proposed now two arrays packed $_POST and $_FILES

Why the $inpit_stream accepts null - does it make sense to invoke the
function then?

--000000000000789a7e06079b23a7--