Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:121300
MIME-Version: 1.0
References: <a973a0f1-6a1d-0219-2059-823d2db497d4@mabe.berlin>
 <cf3708ea-63c7-e375-37c0-63579316c70e@bastelstu.be> <27a9b151-09d7-d5ea-bc0b-c85f8ab0e4ee@mabe.berlin>
 <6ae95177-e0f3-491c-015b-8275f572fb4d@bastelstu.be> <ba27c61d-8d94-6d3d-18ad-a90e0a57e59f@mabe.berlin>
 <a6b6c208-bfeb-d892-33f6-64d587714fc2@bastelstu.be>
In-Reply-To: <a6b6c208-bfeb-d892-33f6-64d587714fc2@bastelstu.be>
Date: Fri, 13 Oct 2023 12:40:58 +0100
Message-ID: <CAEKnhAGo7L+UbqU6RucY3vNn7tzFiMjVV1wwb8fZrCGPgF0URg@mail.gmail.com>
To: =?UTF-8?Q?Tim_D=C3=BCsterhus?= <tim@bastelstu.be>
Cc: internals@lists.php.net
Content-Type: multipart/alternative; boundary="0000000000005d170c0607978814"
Subject: Re: [PHP-DEV] [RFC] [Discussion] Rounding Integers as int
From: bukka@php.net (Jakub Zelenka)

--0000000000005d170c0607978814
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Oct 5, 2023 at 8:57=E2=80=AFPM Tim D=C3=BCsterhus <tim@bastelstu.be=
> wrote:

> While this is not a bug fix that is appropriate for the current stable
> branches, I don't see why it would not be appropriate for PHP 8.4 if
> there's an RFC for it.
>
> In fact there is already a rounding bugfix (no RFC for that) in PHP 8.4:
>
>
> https://github.com/php/php-src/blob/65a8c70f93ccb7e008de147cd4c357681c653=
bd0/UPGRADING#L75-L82
>
>
This is however very different case as it is still following the currently
voted rounding RFC so it is a more bug fix.

Changing the return type of a heavily used function is a completely
different matter. It will break for anyone using is_float or expecting the
float in some other way. I realise that there is an implicit conversion so
it's not such a huge problem most of the time but there might be case where
it is an issue.

I don't see it as a bug fix in any way. It's more just an implication of
the return type being a float.

I think we should always weight the implication of the break. The way that
I see it that some small breaks are acceptable for minor version but bigger
breaks should be done only in major version. I would consider this (and
anything changing a return types) as a bigger break.

Cheers

Jakub

--0000000000005d170c0607978814--