Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:121290
MIME-Version: 1.0
References: <CAOfzkkyTkfCKfuLyyGNvrbEORDDxNSetbqtg1WnMO2fzbeyWdw@mail.gmail.com>
 <CAGBsUrdaKzG8PYS5ubZTP9Mq0xSO84wSwi=mm2ChcTYWpgNUGA@mail.gmail.com> <CAOfzkkyioEQA=XPqnOWmr7tMaziBvG6yFETjdvkZug8V19v_pw@mail.gmail.com>
In-Reply-To: <CAOfzkkyioEQA=XPqnOWmr7tMaziBvG6yFETjdvkZug8V19v_pw@mail.gmail.com>
Date: Fri, 13 Oct 2023 02:36:21 +0200
Message-ID: <CAPzBOBNFr3X1NMhNdoKbPRWOfhXfYXF44cpQYr3HcRsCBxW9KQ@mail.gmail.com>
To: Karoly Negyesi <karoly@negyesi.net>
Cc: Kamil Tekiela <tekiela246@gmail.com>, PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Expose pdo_parse_params to userspace
From: landers.robert@gmail.com (Robert Landers)

On Wed, Oct 11, 2023 at 8:36=E2=80=AFPM Karoly Negyesi <karoly@negyesi.net>=
 wrote:
>
> That's rather concerning on both fronts.
>
> Drupal doesn't plan on abandoning PDO, I believe. At least I haven't seen
> that proposed.
>
> Is there anything I could help with fixing pdo_parse_params ?
>
> Also what's the problem with mysqli async? With fibers introduced in 8.1 =
it
> seems a very good fit , where can I read / help on problems with this
> pairing?
>
> Thanks
>
> Karoly Negyesi
>
>
> On Wed, Oct 11, 2023 at 5:47=E2=80=AFPM Kamil Tekiela <tekiela246@gmail.c=
om> wrote:
>
> > Hi,
> >
> > I have to say I am not a fan of this proposal. While definitely a super
> > nice feature in PDO, it's more of a hack rather than proper feature.
> > Certain RDBMSs support named parameters in prepared statements, but MyS=
QL
> > doesn't. Therefore, the solution implemented in PDO is a hack. It's ver=
y
> > flawed and the current implementation has multiple bugs and shortcoming=
s.
> > One could say that some bugs are security issues.
> >
> > For the above reason, I don't think we should support this in mysqli. W=
e
> > cannot reliably implement such feature. We could make a copy of
> > pdo_parse_params and fix as many MySQL issues as possible, but we would
> > never be able to fix it fully due to the nature of MySQL API.
> >
> > If someone wants to implement this in userland, then be my guest. As lo=
ng
> > as you are aware of the shortcomings and you know how to use it safely =
then
> > it's fine.
> >
> > Unrelated, but I would not consider the async feature of mysqli useful =
or
> > even a good reason to abandon PDO. IMHO the async feature is a failed
> > experiment with limited applicability.
> >
> > Regards,
> > Kamil Tekiela
> >

There isn't a PHP event loop, so fibers are basically useless in
Drupal, unless Drupal is going to provide their own or use Revolt, or
something. In that case, you pretty much have to change your entire
programming model to work with it and accept the interrupts. It's
funny because fibers were intended to prevent the 'what color is your
function' problem, but instead it became the 'I have no idea what
color my function is' problem. So, just like with async/await, you
have to go all-in or none-at-all, or very carefully craft your stack
to handle multiple layers of fibers. Or maybe I've just been "doing it
wrong" which is certainly possible.