Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:121275
Return-Path: <saki@sakiot.com>
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 88384 invoked from network); 12 Oct 2023 04:30:06 -0000
Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5)
  by pb1.pair.com with SMTP; 12 Oct 2023 04:30:06 -0000
Received: from php-smtp4.php.net (localhost [127.0.0.1])
	by php-smtp4.php.net (Postfix) with ESMTP id 021D71804B4
	for <internals@lists.php.net>; Wed, 11 Oct 2023 21:30:05 -0700 (PDT)
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net
X-Spam-Level: 
X-Spam-Status: No, score=-0.7 required=5.0 tests=BAYES_05,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,
	T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.2
X-Spam-ASN: AS9370 160.16.128.0/17
X-Spam-Virus: No
X-Envelope-From: <saki@sakiot.com>
Received: from mail.sakiot.com (mail.sakiot.com [160.16.227.216])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256)
	(No client certificate requested)
	by php-smtp4.php.net (Postfix) with ESMTPS
	for <internals@lists.php.net>; Wed, 11 Oct 2023 21:30:04 -0700 (PDT)
Received: from smtpclient.apple (197.150.159.133.rev.vmobile.jp [133.159.150.197])
	(using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))
	(No client certificate requested)
	by mail.sakiot.com (Postfix) with ESMTPSA id DC4784012E
	for <internals@lists.php.net>; Thu, 12 Oct 2023 13:30:00 +0900 (JST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=sakiot.com;
	s=default; t=1697085000;
	bh=RGAawRDLrAbIgQBugur6wZWi+iVB2wbdnhLMp8Ta7lU=;
	h=From:Date:Subject:To:From;
	b=XR1hrdJcXECmkj0ixdwTvm6uwbqd4ceRudn3DkKJOJWiDYxFvzdy09E2nB9klpJGi
	 YgdSQMpcFN7ZkYgLMsCaGEyuujcbOrVvGocBSKyWyU4n4BLcb7fsV56+rDBtZUZkhV
	 wtEPf8SRbcjY/OHziwB/XP/eJ7vmNWJSQ+btIzOA=
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0 (1.0)
Date: Thu, 12 Oct 2023 13:29:47 +0900
Message-ID: <0874DCA1-E7AC-423B-8402-2F1D45D58D49@sakiot.com>
To: PHP internals <internals@lists.php.net>
X-Mailer: iPhone Mail (20G81)
Subject: Change the signature of odbc_connect
From: saki@sakiot.com (Saki Takamachi)

Hi, internals

I'm currently working on renovating odbc_connect and odbc_pconnect.=20
https://github.com/php/php-src/pull/12306

As a problem came up, I'm planning to create an RFC.

I explain the problem briefly.

In addition to the dsn, these functions have a credential argument. They are=
 required and expect string. The following two cases are problematic here.
1. If the password is set to a blank character ('')
2. For authentication that does not require a password

Since the current signature does not allow nulls, we cannot separate the han=
dling of these cases and must give up on one of them.

Therefore, I am thinking of changing the credential argument to be nullable a=
nd optional for these functions, like pdo.

What do you think?

Best regards.

Saki=