Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:121273 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 63488 invoked from network); 11 Oct 2023 18:36:20 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 11 Oct 2023 18:36:20 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id B4189180504 for ; Wed, 11 Oct 2023 11:36:19 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.2 X-Spam-ASN: AS15169 209.85.128.0/17 X-Spam-Virus: No X-Envelope-From: Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Wed, 11 Oct 2023 11:36:19 -0700 (PDT) Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-9b2d64c9307so3697766b.1 for ; Wed, 11 Oct 2023 11:36:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=negyesi-net.20230601.gappssmtp.com; s=20230601; t=1697049377; x=1697654177; darn=lists.php.net; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=XTuiwxxpj5z3xxhfXS2bCDiEh18Fzso9xkAub0JsL9s=; b=cI1Ge4hEQVQQR2BVYRSbqjMZNU6JwjeqpP4cvuYz+fW/rWJC3mmIDm2Gw6nYKB6e6h ozMjYIO/BZhydsKOsV/3rNb605aZHt+oN1izGJ9vBmYJ1paNvk8Orsr3bFybT74w/pSC iDNxzCke7y2Pi2PxoV/rR9YFW5N4UdUgQtG071GDyDgS6HoSBtSOy7/bLQb0Va6wx2Oc brp5RXVoqR4HLi4ogewK2ZMZjsKg32v14pOkh/A9bD8KLp2YGDi8r9YjUEwp4LmJH7TF 6aLZPsezjLduOQTrh9IoicJQWXPXWWqCyLYjDBmoBvuvhI9EO4vA0RoTzcQ3uJ/0+rDm JqUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697049377; x=1697654177; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XTuiwxxpj5z3xxhfXS2bCDiEh18Fzso9xkAub0JsL9s=; b=sXjt3Q9+L1ZcpUtprDaiAXF9149VkAxGcLyhIyN7MWA6EiGcd2ZveIu6IWXmQSrE5a YSL3NNzeuXxRSvNTC7XQGyJa4U2LYBwB26j7IssvAFGHrEws90hXcxfxROlMBpUNnXe3 H+3WQVa2wtxNPST7YiCrYeozKa/GPl2S6tYagDa37BoEIa/7XFaN/TOJY5j9O/TfGweD SOutZZhllLE252nOGOwyiRc/g7NWvCKizyV6q8YJVqtfvLchYX7J7PZ7atgDXr4bUgno huU6pPu3bi9C/QK2OghFScpxnfxnb1WA2EWIoRGM4EIEW45C5odGttM7bgcRu7J5DZ5z CKMA== X-Gm-Message-State: AOJu0YwGWvGtTYfUjxJRbKvLFMhSjM47h4pk5eIoYSEK5hvLACMI1dQV Ug57RJgsXR9SU4X0VVara8dALYHqiED/Y9QJjS/zSspD X-Google-Smtp-Source: AGHT+IEuswGXLkp6OPxAwTNtL2GgocGzUm3kEAwlqCvyS+WlL1ikb7WJ2N99IClvFcHq9PTwd9IAqw== X-Received: by 2002:a17:906:5308:b0:9b2:b532:d8d7 with SMTP id h8-20020a170906530800b009b2b532d8d7mr18407003ejo.5.1697049377243; Wed, 11 Oct 2023 11:36:17 -0700 (PDT) Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com. [209.85.208.46]) by smtp.gmail.com with ESMTPSA id gh18-20020a170906e09200b009786c8249d6sm10226783ejb.175.2023.10.11.11.36.16 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Oct 2023 11:36:16 -0700 (PDT) Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-53dfc28a2afso335519a12.1 for ; Wed, 11 Oct 2023 11:36:16 -0700 (PDT) X-Received: by 2002:a05:6402:3214:b0:53d:e1d9:a11 with SMTP id g20-20020a056402321400b0053de1d90a11mr1840916eda.35.1697049375747; Wed, 11 Oct 2023 11:36:15 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: Date: Wed, 11 Oct 2023 20:36:04 +0200 X-Gmail-Original-Message-ID: Message-ID: To: Kamil Tekiela Cc: PHP internals Content-Type: multipart/alternative; boundary="00000000000035384d06077519aa" Subject: Re: [PHP-DEV] Expose pdo_parse_params to userspace From: karoly@negyesi.net (Karoly Negyesi) --00000000000035384d06077519aa Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable That's rather concerning on both fronts. Drupal doesn't plan on abandoning PDO, I believe. At least I haven't seen that proposed. Is there anything I could help with fixing pdo_parse_params ? Also what's the problem with mysqli async? With fibers introduced in 8.1 it seems a very good fit , where can I read / help on problems with this pairing? Thanks Karoly Negyesi On Wed, Oct 11, 2023 at 5:47=E2=80=AFPM Kamil Tekiela wrote: > Hi, > > I have to say I am not a fan of this proposal. While definitely a super > nice feature in PDO, it's more of a hack rather than proper feature. > Certain RDBMSs support named parameters in prepared statements, but MySQL > doesn't. Therefore, the solution implemented in PDO is a hack. It's very > flawed and the current implementation has multiple bugs and shortcomings. > One could say that some bugs are security issues. > > For the above reason, I don't think we should support this in mysqli. We > cannot reliably implement such feature. We could make a copy of > pdo_parse_params and fix as many MySQL issues as possible, but we would > never be able to fix it fully due to the nature of MySQL API. > > If someone wants to implement this in userland, then be my guest. As long > as you are aware of the shortcomings and you know how to use it safely th= en > it's fine. > > Unrelated, but I would not consider the async feature of mysqli useful or > even a good reason to abandon PDO. IMHO the async feature is a failed > experiment with limited applicability. > > Regards, > Kamil Tekiela > --00000000000035384d06077519aa--