Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:121240
Message-ID: <a6b6c208-bfeb-d892-33f6-64d587714fc2@bastelstu.be>
Date: Thu, 5 Oct 2023 21:57:36 +0200
MIME-Version: 1.0
Content-Language: en-US
To: internals@lists.php.net
References: <a973a0f1-6a1d-0219-2059-823d2db497d4@mabe.berlin>
 <cf3708ea-63c7-e375-37c0-63579316c70e@bastelstu.be>
 <27a9b151-09d7-d5ea-bc0b-c85f8ab0e4ee@mabe.berlin>
 <6ae95177-e0f3-491c-015b-8275f572fb4d@bastelstu.be>
 <ba27c61d-8d94-6d3d-18ad-a90e0a57e59f@mabe.berlin>
In-Reply-To: <ba27c61d-8d94-6d3d-18ad-a90e0a57e59f@mabe.berlin>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] [RFC] [Discussion] Rounding Integers as int
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=c3=bcsterhus?=)

Hi

On 10/4/23 08:35, Marc Bennewitz wrote:
> As far as I understand you are in favor of option 1. (considering it a
> bugfix) but how do you make sure this will not lead to different
> application behavior overlooked on upgrading? Also there is no way to
> opt-in new behavior.
> 

Yes, I would be in favor of option 1 and I don't even see a reason not 
to do this in PHP 8.4 right away. As I mentioned before, this 
effectively can be considered a bug fix: PHP does not correctly round 
integers > 2^53.

While this is not a bug fix that is appropriate for the current stable 
branches, I don't see why it would not be appropriate for PHP 8.4 if 
there's an RFC for it.

In fact there is already a rounding bugfix (no RFC for that) in PHP 8.4:

https://github.com/php/php-src/blob/65a8c70f93ccb7e008de147cd4c357681c653bd0/UPGRADING#L75-L82

While PHP tries hard to keep backwards compatibility within a given 
major, keeping full compatibility is effectively impossible for the huge 
API surface PHP exposes. Every version includes *some* changes that are 
technically breaking for one reason or another.

Best regards
Tim Düsterhus