Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:121223
MIME-Version: 1.0
References: <CAPTD5yEcwBNUe2Y9vvmHaigFtvRixJ0anTuLk4zXOKvBhrUOig@mail.gmail.com>
 <CAPTD5yFskA6okAQNzG1XZ5SAePbm-GUD-33d5TVsCpP6oZtP4w@mail.gmail.com>
In-Reply-To: <CAPTD5yFskA6okAQNzG1XZ5SAePbm-GUD-33d5TVsCpP6oZtP4w@mail.gmail.com>
Date: Thu, 5 Oct 2023 00:26:22 +0100
Message-ID: <CAFPFaMKWQCdUeSDei6LpPp-biteDYDVGtbduv_S2wTkTRiEn0Q@mail.gmail.com>
To: Jorg Sowa <jorg.sowa@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000008a474b0606ec56b0"
Subject: Re: [PHP-DEV] Re: [RFC] [Discussion] Add 4 new rounding modes to
 round() function
From: george.banyard@gmail.com ("G. P. B.")

--0000000000008a474b0606ec56b0
Content-Type: text/plain; charset="UTF-8"

On Wed, 4 Oct 2023 at 23:23, Jorg Sowa <jorg.sowa@gmail.com> wrote:

> Thank you all for the discussion. I modified description of the RFC and
> added deprecation of constants ROUND_UP and ROUND_DOWN from Intl extension
> as an additional voting.
>
> Thanks also for input about possible mode ROUND_STOCHASTIC, however I think
> it's the idea for the extension and not the addition to the standard
> functions.
>
> I would like to start the voting in coming days.
>

I don't think deprecating the constants in the version where the aliases
are introduced is a good idea.
There needs to be at least one version where both variants exist to allow
for cross version compatibility.

I will also echo Tim's idea of using an enum instead and a union type.
For the namespace, I think it would make sense to use Maths\RoundingMode

Best regards,

George P. Banyard

--0000000000008a474b0606ec56b0--