Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:121173
Message-ID: <cf3708ea-63c7-e375-37c0-63579316c70e@bastelstu.be>
Date: Fri, 29 Sep 2023 17:28:28 +0200
MIME-Version: 1.0
To: Marc Bennewitz <marc@mabe.berlin>, PHP internals <internals@lists.php.net>
References: <a973a0f1-6a1d-0219-2059-823d2db497d4@mabe.berlin>
Content-Language: en-US
In-Reply-To: <a973a0f1-6a1d-0219-2059-823d2db497d4@mabe.berlin>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] [RFC] [Discussion] Rounding Integers as int
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=c3=bcsterhus?=)

Hi

On 9/26/23 12:39, Marc Bennewitz wrote:
> I'd like to put a new RFC under discussion:
> https://wiki.php.net/rfc/integer-rounding

I find the proposal reasonable, but I don't like the deprecation 
proposal, because it does not allow me to opt into the *new* behavior 
before PHP 9.0 arrives.

Getting rid of the deprecation would also require me to either add a 
cast everywhere or add the error suppression operator everywhere and 
then revert that with PHP 9 depending on whether I want the new behavior 
or not.

As far as I can tell all the other deprecations allow me to use the 
replacement functionality right away without needing to go through a 
two-step process.

As the results of not casting to float first are arguably more correct, 
perhaps this could be considered a bugfix. While it would cause breakage 
for users that rely on strict types, obtaining the old behavior is just 
one `(float)` cast away.

Best regards
Tim Düsterhus