Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:121148
Feedback-ID: i8414410d:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-957-ga1ccdb4cff-fm-20230919.001-ga1ccdb4c
MIME-Version: 1.0
Message-ID: <b09bda36-742f-4baa-9710-871c494d5d2c@app.fastmail.com>
In-Reply-To: <a973a0f1-6a1d-0219-2059-823d2db497d4@mabe.berlin>
References: <a973a0f1-6a1d-0219-2059-823d2db497d4@mabe.berlin>
Date: Tue, 26 Sep 2023 18:41:08 +0000
To: "php internals" <internals@lists.php.net>
Content-Type: text/plain
Subject: Re: [PHP-DEV] [RFC] [Discussion] Rounding Integers as int
From: larry@garfieldtech.com ("Larry Garfield")

On Tue, Sep 26, 2023, at 10:39 AM, Marc Bennewitz wrote:
> Hi internals
>
> I'd like to put a new RFC under discussion:
> https://wiki.php.net/rfc/integer-rounding
>
> Best,
> Marc

I'm honestly kind of confused by this.  The basic concept, as I understand it, is sound.  But the rest of the description seems to suggest that the returned type will depend on the passed-in type?  That makes little sense to me.  Since we already know that int is contravariant to float, I would expect round to return int if it can, float if there is a decimal precision set.  ceil and floor should always return ints, unconditionally, because that's literally what their purpose is.  But that RFC doesn't say that, which makes me quite confused.

Similarly, the BC shim would therefore be (float)ceil($x), not ceil((float)$x), which... I don't think that would even do anything, would it?

--Larry Garfield