Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:121109
Message-ID: <c874b79e-903e-c882-6adf-049de6d92b34@bastelstu.be>
Date: Thu, 21 Sep 2023 11:13:14 +0200
MIME-Version: 1.0
Content-Language: en-US
To: Dmitry Stogov <dmitrystogov@gmail.com>,
 PHP Internals <internals@lists.php.net>
References: <CAPVMwwt8dgJGQKVsHt5=YRbx7VwqnXWOua99vsQPY2LWx9xxFw@mail.gmail.com>
In-Reply-To: <CAPVMwwt8dgJGQKVsHt5=YRbx7VwqnXWOua99vsQPY2LWx9xxFw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] [RFC] [Discussion] A new JIT implementation based on IR
 Framework
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=c3=bcsterhus?=)

Hi

On 9/21/23 10:26, Dmitry Stogov wrote:
> After all the Poll Request discussions (see
> https://github.com/php/php-src/pull/12079), code-reviews and internal
> discussions with core developers we decided to move this through the RFC
> process.
> 
> Thanks to all participants.
> 
> The RFC is open for discussion: https://wiki.php.net/rfc/jit-ir

Thank you. I find it important to follow the formal process, even if 
many folks are not able to make a meaningful decision due to the lack of 
knowledge about the topic. This includes me.

That said, I'd like to add my two cents to the "Open Issues" section:

My understanding is that even if the new JIT might not (yet) be better 
than the old one, it is not worse and it is more maintainable. The 
reactions from more knowledgeable folks were pretty positive overall.

So if the new JIT passes the existing test suite without issues, I don't 
see a reason why the old JIT should not be replaced right away. By 
immediately removing the old JIT (ideally in a separate commit) the 
codebase is cleaned up and users that want to test PHP 8.4 (or whatever 
that version may be in the end) will be forced to also test the new JIT 
which is probably a good thing.

Best regards
Tim Düsterhus