Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:121100
Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\))
In-Reply-To: <b8665e13-d317-49a0-b740-b082ec6bd2c9@gmail.com>
Date: Tue, 19 Sep 2023 13:35:48 +0700
Cc: PHP Internals <internals@lists.php.net>
Content-Transfer-Encoding: quoted-printable
Message-ID: <872B9392-D91A-45BC-8956-3E53B16723A6@koalephant.com>
References: <c7a7f77b-8187-23f7-7c02-c92f1b538039@gmail.com>
 <c774ef73-802b-42eb-9181-9a080713c390@gmail.com>
 <CAAwdEzCQps8+cFf86-6e_7gCXtdhG7DjLTyQ3TS-=3+kW-Pcqg@mail.gmail.com>
 <29eb53a7-9aef-4e48-999e-97574f27a9df@gmail.com>
 <4C6FD028-4E34-4578-AF04-EDAC120E3E94@koalephant.com>
 <b8665e13-d317-49a0-b740-b082ec6bd2c9@gmail.com>
To: Niels Dossche <dossche.niels@gmail.com>
Subject: Re: [PHP-DEV] [RFC] [Discussion] DOM HTML5 parsing and serialization
 support
From: php-lists@koalephant.com (Stephen Reay)


> On 19 Sep 2023, at 01:00, Niels Dossche=20
>=20
> Cheers
> Niels
>=20
> --=20
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: https://www.php.net/unsub.php



(Resending with history removed due to apparent size limit)=20

Hi Niels,

Obviously, a method with different signatures (`fromEmptyDocument`) =
can't be in the parent, and I'll discuss that below, but having the =
other factory methods that do have the same signature in parent (even if =
only an abstract method, forcing concrete implementations to define it) =
means that it's possible to *safely* do meta-programming with these =
classes, where you load a string/file, using a classname from a =
variable. This use-case doesn't necessarily need to know which specific =
instance it's getting back, so long as it's an instance of the base =
class (or interface, if it had been one), but that information can still =
be presented, via the return type (either `static`, or `self` on the =
parent and the actual class name on each of the implementations).


Regarding the private constructor: I understand the issue with the *old* =
class being confusing - but your new class doesn't have that issue, =
because there are no "loadXXX" methods: as you said, if you're loading =
an existing document, you're forced to do it via the static factory =
methods. With that change alone, there's zero risk of confusion in =
allowing direct constructor calls, because once the object is =
instantiated there is no subsequent way to load a document and =
inadvertently change the encoding.

Having a regular constructor and then one or more factory methods for =
specific cases is already a concept in PHP (i.e. DateTime[Immutable]'s  =
`createFromXXX` as well as a constructor), and IMO needing to call a =
factory method to get an "empty" document seems out of place in PHP - it =
seems a bit like a Java-ism - using a factory, where one just isn't =
required.


Cheers

Stephen