Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:121077
MIME-Version: 1.0
References: <c7a7f77b-8187-23f7-7c02-c92f1b538039@gmail.com> <c774ef73-802b-42eb-9181-9a080713c390@gmail.com>
In-Reply-To: <c774ef73-802b-42eb-9181-9a080713c390@gmail.com>
Date: Sun, 17 Sep 2023 12:59:33 +0300
Message-ID: <CAAwdEzCQps8+cFf86-6e_7gCXtdhG7DjLTyQ3TS-=3+kW-Pcqg@mail.gmail.com>
To: Niels Dossche <dossche.niels@gmail.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000f8be9406058b1502"
Subject: Re: [PHP-DEV] Re: [RFC] [Discussion] DOM HTML5 parsing and
 serialization support
From: drealecs@gmail.com (=?UTF-8?Q?Alexandru_P=C4=83tr=C4=83nescu?=)

--000000000000f8be9406058b1502
Content-Type: text/plain; charset="UTF-8"

On Sat, Sep 16, 2023, 02:17 Niels Dossche <dossche.niels@gmail.com> wrote:

>
> We'll add a common abstract base class DOM\Document (name taken from the
> DOM spec & Javascript world).
> DOM\Document contains the properties and abstract methods common to both
> HTML and XML documents.
>
>
Hi,

Yes looks a lot better.
Great work overall! And thank you for taking on this effort.

I would have a small suggestion: to make the abstract class an interface.
This will allow even more flexibility on how things can be build further,
suggesting composition over inheritance.
In user land we cannot have interfaces with properties (yet) but in php
internal interfaces we have example with interface UnitEnum that has name
property, extendes by BackedEnum that adds value property.

Thank you,
Alex

--000000000000f8be9406058b1502--