Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:121074
MIME-Version: 1.0
References: <CAPVMwwtcLwq8AGEBYCXB1-HngS1R0D-xM5kTGjYqEdjmB7M=ag@mail.gmail.com>
 <CAPVMwwu9+RK13ByqFpexrQ4Sc+xARvyQb=WVxruhVtGKzxjo+A@mail.gmail.com>
 <8b9a1aae-5aec-91a8-5377-27f6f53581cd@php.net> <ac239e29-edb5-3976-4df0-4a92ec6ea4ad@bastelstu.be>
In-Reply-To: <ac239e29-edb5-3976-4df0-4a92ec6ea4ad@bastelstu.be>
Date: Sat, 16 Sep 2023 11:46:16 +0200
Message-ID: <CAJmy8YF=+zqtSru1joW2UbMR3RkYu3akHmruYfFwTCZ7-iR+_A@mail.gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000086bb85060576c843"
Subject: Re: [PHP-DEV] A new JIT engine for PHP-8.4/9
From: divinity76@gmail.com (Hans Henrik Bergan)

--00000000000086bb85060576c843
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

I think the submodule approach is fine, but maybe it should be moved from
Dmitry's gh to php-src gh, or maybe it's own dedicated group, to reduce the
bus factor (how much work needs to be done if Dmitry is hit by a bus~)

On Sat, Sep 16, 2023, 00:22 Tim D=C3=BCsterhus <tim@bastelstu.be> wrote:

> Hi
>
> On 9/15/23 17:50, Ben Ramsey wrote:
> > Additionally, despite the use of a Git submodule complicating things fo=
r
> > "everyone else," it provides a clear dependency and development
> > boundary, avoiding situations where the php-src version of IR drifts
> > from the upstream version. I think we can adjust tooling and messaging
> > to help folks know how to use the submodule. :-)
>
> Do not want: If the submodule repository goes away for whatever reason,
> the dependency will no longer be available. IR is currently sitting in
> Dmitry's personal GitHub account and it would not be the first time that
> a GitHub account is suspended for good or less good reasons [1].
>
> Bundle IR in some dedicated directory with php-src. Then updating it is
> as easy as "throw away the directory and copy over the new files". We
> could even automate that using GitHub actions to sync in the changes
> every night or so.
>
> Dmitry also said that he gave 'git subtree' a try. I don't know that
> command myself, but it looks exactly like what is required here. I would
> be interested in hearing why it didn't work well.
>
> Best regards
> Tim D=C3=BCsterhus
>
> [1] Such as sanctions, see:
> https://techcrunch.com/2019/07/29/github-ban-sanctioned-countries/
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: https://www.php.net/unsub.php
>
>

--00000000000086bb85060576c843--