Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:121057
Message-ID: <64542532-150b-df63-0c2f-3382f99fe0f4@bastelstu.be>
Date: Wed, 13 Sep 2023 21:44:33 +0200
MIME-Version: 1.0
Content-Language: en-US
To: Ben Ramsey <ramsey@php.net>, internals@lists.php.net
References: <01e3ff17-5088-0431-6014-82ef4e4789b2@bastelstu.be>
 <48699eff-c0d1-43de-b68e-2327fa601528@gmail.com>
In-Reply-To: <48699eff-c0d1-43de-b68e-2327fa601528@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] Casing of acronyms in class and method names
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=c3=bcsterhus?=)

Hi

On 9/11/23 01:57, Ben Ramsey wrote:
> Since class names in PHP aren't case-sensitive, there should be no BC
> concerns for changing existing classes to fit this new casing (for
> Reflection, debug, and documentation purposes). That is, if we wanted to
> also update all existing class names in PHP that contain acronyms (e.g.,
> DOMDocument -> DomDocument, SimpleXMLElement -> SimpleXmlElement, etc.).
> 

Userland string comparisons against the classname would break. In the 
simplest case the following:

     if (get_class($someObject) === 'DOMDocument') {
         // do something
     }

It most certainly isn't *great* code, but I don't find it completely 
unreasonable. Especially if the code dates back from before `::class` 
was added.

Best regards
Tim Düsterhus